From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16CFFC433DB for ; Wed, 24 Feb 2021 15:38:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5477664EDB for ; Wed, 24 Feb 2021 15:38:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5477664EDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEwEy-0007f8-5t for qemu-devel@archiver.kernel.org; Wed, 24 Feb 2021 10:38:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEwCg-0005gX-DB for qemu-devel@nongnu.org; Wed, 24 Feb 2021 10:35:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEwCe-0001GF-N5 for qemu-devel@nongnu.org; Wed, 24 Feb 2021 10:35:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614180952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UFZmlzTAuEGE6ZFch0ja74QQhkiVv6QNCnOoPAPVKCM=; b=Xs6bE952YfnnngGoL+7T15MkQYwD7kRki3HWLQWZGRIF35/aynfOxAiLRr5A1N+FONgV/Z /A/cH5lBKZQNF+Y4G29mZvhlQmP0WkJPG6FLkRFjrCi5BqzXNouLgUX75QZDFYqGnq8bza wSwOW+6VVkVv7mGrc5G9HoC0uXHZAGs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-nc2uN8ykNpyDaY7DE5NRew-1; Wed, 24 Feb 2021 10:35:48 -0500 X-MC-Unique: nc2uN8ykNpyDaY7DE5NRew-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63C6B1103897; Wed, 24 Feb 2021 15:01:51 +0000 (UTC) Received: from thuth.remote.csb (ovpn-115-142.ams2.redhat.com [10.36.115.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63DD06E505; Wed, 24 Feb 2021 15:01:25 +0000 (UTC) Subject: Re: [PATCH 11/14] block: remove 'encryption_key_missing' flag from QAPI To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20210224131142.1952027-1-berrange@redhat.com> <20210224131142.1952027-12-berrange@redhat.com> From: Thomas Huth Message-ID: <6884bef5-3d1a-cde8-5429-31987b7e2f6b@redhat.com> Date: Wed, 24 Feb 2021 16:01:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210224131142.1952027-12-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , "Michael S. Tsirkin" , libvir-list@redhat.com, Mark Cave-Ayland , Gerd Hoffmann , qemu-block@nongnu.org, Juan Quintela , Markus Armbruster , Wainer dos Santos Moschetta , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Artyom Tarasenko , Laurent Vivier , Eduardo Habkost , Richard Henderson , "Dr. David Alan Gilbert" , Greg Kurz , Cleber Rosa , John Snow , David Gibson , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Max Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24/02/2021 14.11, Daniel P. Berrangé wrote: > This has been hardcoded to "false" since 2.10.0, since secrets required > to unlock block devices are now always provided upfront instead of using > interactive prompts. > > Signed-off-by: Daniel P. Berrangé > --- > block/qapi.c | 1 - > docs/system/deprecated.rst | 10 ------- > docs/system/removed-features.rst | 10 +++++++ > qapi/block-core.json | 8 ------ > tests/qemu-iotests/184.out | 6 ++-- > tests/qemu-iotests/191.out | 48 +++++++++++--------------------- > tests/qemu-iotests/273.out | 15 ++++------ > 7 files changed, 33 insertions(+), 65 deletions(-) > > diff --git a/block/qapi.c b/block/qapi.c > index 84a0aadc09..3acc118c44 100644 > --- a/block/qapi.c > +++ b/block/qapi.c > @@ -62,7 +62,6 @@ BlockDeviceInfo *bdrv_block_device_info(BlockBackend *blk, > info->ro = bs->read_only; > info->drv = g_strdup(bs->drv->format_name); > info->encrypted = bs->encrypted; > - info->encryption_key_missing = false; > > info->cache = g_new(BlockdevCacheInfo, 1); > *info->cache = (BlockdevCacheInfo) { > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst > index cb88fea94f..e746a63edf 100644 > --- a/docs/system/deprecated.rst > +++ b/docs/system/deprecated.rst > @@ -147,16 +147,6 @@ Use argument ``id`` instead. > > Use argument ``id`` instead. > > -``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0) > -'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > - > -Always false. > - > -``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0) > -''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > - > -Always false. > - > ``blockdev-add`` empty string argument ``backing`` (since 2.10.0) > ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > > diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst > index bb6bc8dfc8..583f14f02e 100644 > --- a/docs/system/removed-features.rst > +++ b/docs/system/removed-features.rst > @@ -112,6 +112,16 @@ chardev client socket with ``wait`` option (removed in 6.0) > Character devices creating sockets in client mode should not specify > the 'wait' field, which is only applicable to sockets in server mode > > +``query-named-block-nodes`` result ``encryption_key_missing`` (removed in 6.0) > +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > + > +Always false. Should that be "Removed with no replacement", too ? (just like the one below) > +``query-block`` result ``inserted.encryption_key_missing`` (removed in 6.0) > +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' > + > +Removed with no replacement > + Apart from that nit: Reviewed-by: Thomas Huth