From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52424)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clg@kaod.org>) id 1bmiSN-0005se-Co
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:25:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clg@kaod.org>) id 1bmiSG-0005VT-O7
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:25:02 -0400
Received: from 9.mo69.mail-out.ovh.net ([46.105.56.78]:46140)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <clg@kaod.org>)
	id 1bmiSG-0005VG-IK
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 10:24:56 -0400
Received: from player779.ha.ovh.net (b9.ovh.net [213.186.33.59])
	by mo69.mail-out.ovh.net (Postfix) with ESMTP id C45D5100834E
	for <qemu-devel@nongnu.org>; Wed, 21 Sep 2016 16:24:55 +0200 (CEST)
References: <1473943560-14846-1-git-send-email-clg@kaod.org>
	<1473943560-14846-6-git-send-email-clg@kaod.org>
	<20160921015156.GP20488@umbus>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
Message-ID: <688a7f2a-3189-3c6f-3c06-84d1b0edab53@kaod.org>
Date: Wed, 21 Sep 2016 16:24:49 +0200
MIME-Version: 1.0
In-Reply-To: <20160921015156.GP20488@umbus>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 05/10] ppc/pnv: add a PnvCore object
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>, qemu-devel@nongnu.org

>> +static void powernv_cpu_init(PowerPCCPU *cpu, Error **errp)
>> +{
>> +    CPUPPCState *env = &cpu->env;
>> +
>> +    /* Set time-base frequency to 512 MHz */
>> +    cpu_ppc_tb_init(env, PNV_TIMEBASE_FREQ);
>> +
>> +    /* MSR[IP] doesn't exist nowadays */
>> +    env->msr_mask &= ~(1 << 6);
> 
> If MSR[IP] is gone, shouldn't that be reflected in the MSR masks
> stored for the actual vcpu models, rather than imposed from the
> machine or core code?

So, this is MSR[EP] and it is not in the msr mask of the CPUs PowerNV
runs on. We can just drop the line.

C.