From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
qemu-devel@nongnu.org
Cc: "Volker R ü melin" <vr_qemu@t-online.de>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [PATCH-for-8.2] virtio-sound: add realize() error cleanup path
Date: Thu, 16 Nov 2023 09:42:57 +0100 [thread overview]
Message-ID: <688bc783-e56f-4e24-95f6-a69aa4bc8863@linaro.org> (raw)
In-Reply-To: <47h4g.6wu5d10yw748@linaro.org>
On 16/11/23 08:33, Manos Pitsidianakis wrote:
> On Thu, 16 Nov 2023 09:32, Philippe Mathieu-Daudé <philmd@linaro.org>
> wrote:
>>> ---
>>>
>>> Notes:
>>> Requires patch
>>> <20231109162034.2108018-1-manos.pitsidianakis@linaro.org>
>>
>> This is the 'Based-on: ' tag I guess.
>
> There is
>
> prerequisite-patch-id: 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
$ git show 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
fatal: bad object 484ec9f7f6109c10d4be0484fe8e3c2550c415f4
In which tree can we find this commit? Better to use the msg-id,
so tools cat fetch prerequisite.
I guess the 'patches' tool understand 'Based-on'. Or was it 'patchew'?
> At the end of the patch, added by git-format-patch. Is it best practice
> to include it in the commit message too?
I don't use git-format-patch directly anymore, but via git-publish.
Ideally we'd teach git-publish to record/publish email msg-ids and b4
to consume them...
Maybe worth suggesting as feature request, similarly to
https://github.com/stefanha/git-publish/issues/84 with the 'Supersedes:'
tag?
Phil.
next prev parent reply other threads:[~2023-11-16 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 7:20 [PATCH-for-8.2] virtio-sound: add realize() error cleanup path Manos Pitsidianakis
2023-11-16 7:32 ` Philippe Mathieu-Daudé
2023-11-16 7:33 ` Manos Pitsidianakis
2023-11-16 8:42 ` Philippe Mathieu-Daudé [this message]
2023-11-16 8:48 ` Manos Pitsidianakis
2023-11-16 8:54 ` Philippe Mathieu-Daudé
2023-11-16 9:16 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=688bc783-e56f-4e24-95f6-a69aa4bc8863@linaro.org \
--to=philmd@linaro.org \
--cc=kraxel@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).