From: Richard Henderson <richard.henderson@linaro.org>
To: "Ilya Leoshkevich" <iii@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Peter Xu" <peterx@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 4/4] accel/tcg: Move perf and debuginfo support to tcg
Date: Mon, 11 Dec 2023 10:52:00 -0800 [thread overview]
Message-ID: <689acd01-fbd5-44a2-a1c9-cef4ea2b734d@linaro.org> (raw)
In-Reply-To: <20231208003754.3688038-5-iii@linux.ibm.com>
On 12/7/23 16:35, Ilya Leoshkevich wrote:
> --- a/accel/tcg/translate-all.c
> +++ b/accel/tcg/translate-all.c
> @@ -63,7 +63,7 @@
> #include "tb-context.h"
> #include "internal-common.h"
> #include "internal-target.h"
> -#include "perf.h"
> +#include "tcg/perf.h"
> #include "tcg/insn-start-words.h"
Because this header is used outside of tcg/, the header should be include/tcg/perf.h.
> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index e7a9b3775bb..b8e52f3fb0f 100644
> --- a/hw/core/loader.c
> +++ b/hw/core/loader.c
> @@ -62,7 +62,7 @@
> #include "hw/boards.h"
> #include "qemu/cutils.h"
> #include "sysemu/runstate.h"
> -#include "accel/tcg/debuginfo.h"
> +#include "tcg/debuginfo.h"
>
> #include <zlib.h>
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index cf9e74468b1..62120c76151 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -21,7 +21,7 @@
> #include "qapi/error.h"
> #include "qemu/error-report.h"
> #include "target_signal.h"
> -#include "accel/tcg/debuginfo.h"
> +#include "tcg/debuginfo.h"
>
> #ifdef TARGET_ARM
> #include "target/arm/cpu-features.h"
Likewise.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-12-11 18:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 0:35 [PATCH v3 0/4] accel/tcg: Move perf and debuginfo support to tcg Ilya Leoshkevich
2023-12-08 0:35 ` [PATCH v3 1/4] target: Make qemu_target_page_mask() available for *-user Ilya Leoshkevich
2023-12-08 10:58 ` Philippe Mathieu-Daudé
2023-12-08 0:35 ` [PATCH v3 2/4] tcg: Make tb_cflags() usable from target-agnostic code Ilya Leoshkevich
2023-12-11 18:47 ` Richard Henderson
2023-12-08 0:35 ` [PATCH v3 3/4] accel/tcg: Remove #ifdef TARGET_I386 from perf.c Ilya Leoshkevich
2023-12-08 9:53 ` Alex Bennée
2023-12-08 10:35 ` Ilya Leoshkevich
2023-12-11 18:49 ` Richard Henderson
2023-12-08 0:35 ` [PATCH v3 4/4] accel/tcg: Move perf and debuginfo support to tcg Ilya Leoshkevich
2023-12-11 18:52 ` Richard Henderson [this message]
2023-12-08 11:01 ` [PATCH v3 0/4] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=689acd01-fbd5-44a2-a1c9-cef4ea2b734d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).