From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Sebastian Bauer <mail@sebastianbauer.info>,
Magnus Damm <magnus.damm@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 3/6] sm501: Use BIT(x) macro to shorten constant
Date: Thu, 21 May 2020 16:10:20 +0200 [thread overview]
Message-ID: <68a23558-5bf2-8d91-a490-1c631f9a881a@redhat.com> (raw)
In-Reply-To: <6c63555cc4023d05e550d513112f472a2020a117.1589981990.git.balaton@eik.bme.hu>
On 5/20/20 3:39 PM, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/display/sm501.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index f42d05e1e4..97660090bb 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -701,7 +701,7 @@ static void sm501_2d_operation(SM501State *s)
> {
> /* obtain operation parameters */
> int cmd = (s->twoD_control >> 16) & 0x1F;
> - int rtl = s->twoD_control & 0x8000000;
> + int rtl = s->twoD_control & BIT(27);
> int src_x = (s->twoD_source >> 16) & 0x01FFF;
> int src_y = s->twoD_source & 0xFFFF;
> int dst_x = (s->twoD_destination >> 16) & 0x01FFF;
> @@ -751,8 +751,7 @@ static void sm501_2d_operation(SM501State *s)
> }
> }
>
> - if ((s->twoD_source_base & 0x08000000) ||
> - (s->twoD_destination_base & 0x08000000)) {
> + if (s->twoD_source_base & BIT(27) || s->twoD_destination_base & BIT(27)) {
> qemu_log_mask(LOG_UNIMP, "sm501: only local memory is supported.\n");
> return;
> }
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-05-21 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:39 [PATCH 0/6] Misc display/sm501 clean ups and fixes BALATON Zoltan
2020-05-20 13:39 ` [PATCH 5/6] sm501: Replace hand written implementation with pixman where possible BALATON Zoltan
2020-05-20 13:39 ` [PATCH 4/6] sm501: Clean up local variables in sm501_2d_operation BALATON Zoltan
2020-05-21 14:09 ` Philippe Mathieu-Daudé
2020-05-20 13:39 ` [PATCH 2/6] sm501: Shorten long variable names " BALATON Zoltan
2020-05-20 13:39 ` [PATCH 1/6] sm501: Convert printf + abort to qemu_log_mask BALATON Zoltan
2020-05-21 14:07 ` Philippe Mathieu-Daudé
2020-05-20 13:39 ` [PATCH 6/6] sm501: Remove obsolete changelog and todo comment BALATON Zoltan
2020-05-21 14:08 ` Philippe Mathieu-Daudé
2020-05-20 13:39 ` [PATCH 3/6] sm501: Use BIT(x) macro to shorten constant BALATON Zoltan
2020-05-21 14:10 ` Philippe Mathieu-Daudé [this message]
2020-05-20 17:55 ` [PATCH 0/6] Misc display/sm501 clean ups and fixes BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a23558-5bf2-8d91-a490-1c631f9a881a@redhat.com \
--to=philmd@redhat.com \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=kraxel@redhat.com \
--cc=magnus.damm@gmail.com \
--cc=mail@sebastianbauer.info \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).