From: Richard Henderson <richard.henderson@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-devel@nongnu.org
Cc: danielhb413@gmail.com, david@gibson.dropbear.id.au,
groug@kaod.org, qemu-ppc@nongnu.org,
Nicholas Piggin <npiggin@gmail.com>,
Anton Johansson <anjo@rev.ng>
Subject: Re: [PATCH for-8.0 v2] target/ppc: Fix temp usage in gen_op_arith_modw
Date: Sun, 9 Apr 2023 11:08:54 -0700 [thread overview]
Message-ID: <68a80aab-4aa8-446c-c3cd-f756574c769f@linaro.org> (raw)
In-Reply-To: <72e69d86-cf6c-a621-d2dc-42fc26cbe396@kaod.org>
On 4/9/23 10:29, Cédric Le Goater wrote:
> On 4/9/23 18:21, Richard Henderson wrote:
>> On 4/8/23 14:24, Cédric Le Goater wrote:
>>> On 4/8/23 09:05, Richard Henderson wrote:
>>>> Fix a crash writing to 't3', which is now a constant.
>>>> Instead, write the result of the remu to 't1'.
>>>>
>>>> Fixes: 7058ff5231a ("target/ppc: Avoid tcg_const_* in translate.c")
>>>> Reported-by: Nicholas Piggin <npiggin@gmail.com>
>>>> Reviewed-by: Anton Johansson <anjo@rev.ng>
>>>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>>
>>> Looks good:
>>>
>>> https://gitlab.com/legoater/qemu/-/pipelines/831847446
>>>
>>> I have a PR ready for this same branch. If you want to me send,
>>> just tell.
>>
>> Yes, please. Also, the comment above needs s/t1/t0/. :-P
>
> sure :)
>
> Are you taking care of :
>
> https://lore.kernel.org/r/20230408154316.3812709-1-richard.henderson@linaro.org
Yes, I'll send that with two other tcg fixes.
r~
next prev parent reply other threads:[~2023-04-09 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 7:05 [PATCH for-8.0 v2] target/ppc: Fix temp usage in gen_op_arith_modw Richard Henderson
2023-04-08 21:24 ` Cédric Le Goater
2023-04-09 2:16 ` Nicholas Piggin
2023-04-10 12:50 ` Fabiano Rosas
2023-04-09 16:21 ` Richard Henderson
2023-04-09 17:29 ` Cédric Le Goater
2023-04-09 18:08 ` Richard Henderson [this message]
2023-04-10 11:30 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a80aab-4aa8-446c-c3cd-f756574c769f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anjo@rev.ng \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).