qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Avihai Horon <avihaih@nvidia.com>,
	qemu-devel@nongnu.org,
	Alex Williamson <alex.williamson@redhat.com>,
	Fabiano Rosas <farosas@suse.de>
Subject: Re: [PATCH 2/3] vfio/migration: Refactor vfio_vmstate_change/_prepare() error reporting
Date: Mon, 21 Oct 2024 18:43:13 +0200	[thread overview]
Message-ID: <68d60abe-32b6-49b3-bc60-6c92909252f0@redhat.com> (raw)
In-Reply-To: <ZxZ4Y5KSNPcuN8-X@x1n>

Hello,

> IIUC the migration thread should always see valid migration object, as it
> takes one refcount at the entrance of migration_thread():
> 
>      object_ref(OBJECT(s));

Could the migration have failed before ? in migrate_fd_connect()

> So it's not yet clear to me on why the mutex was destroyed, if the main
> object should still be there; logically it was only destroyed in the
> finalize phase (migration_instance_finalize), but that should be after
> migration thread quits and releases the refcount..


Avihai, would you have a reproducer ? or did you keep some logs ?
a backtrace maybe ?

Thanks,

C.
  



  reply	other threads:[~2024-10-21 16:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-20 13:01 [PATCH 0/3] vfio/migration: Some bug fixes and cleanups Avihai Horon
2024-10-20 13:01 ` [PATCH 1/3] vfio/migration: Report only stop-copy size in vfio_state_pending_exact() Avihai Horon
2024-10-21  6:48   ` Cédric Le Goater
2024-10-23 10:06   ` Cédric Le Goater
2024-10-25 15:18   ` Michael Tokarev
2024-10-25 16:09     ` Cédric Le Goater
2024-10-20 13:01 ` [PATCH 2/3] vfio/migration: Refactor vfio_vmstate_change/_prepare() error reporting Avihai Horon
2024-10-21 15:14   ` Cédric Le Goater
2024-10-21 15:50     ` Peter Xu
2024-10-21 16:43       ` Cédric Le Goater [this message]
2024-10-21 16:54         ` Peter Xu
2024-10-22  9:38           ` Avihai Horon via
2024-10-22 13:24             ` Cédric Le Goater
2024-10-22 14:21               ` Avihai Horon
2024-10-22 14:29               ` Peter Xu
2024-10-22 14:42                 ` Cédric Le Goater
2024-10-22 16:10                   ` Peter Xu
2024-10-20 13:01 ` [PATCH 3/3] vfio/migration: Change trace formats from hex to decimal Avihai Horon
2024-10-21 15:17   ` Cédric Le Goater
2024-10-23 15:08 ` [PATCH 0/3] vfio/migration: Some bug fixes and cleanups Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68d60abe-32b6-49b3-bc60-6c92909252f0@redhat.com \
    --to=clg@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=farosas@suse.de \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).