From: Thomas Huth <thuth@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
philmd@redhat.com
Cc: imammedo@redhat.com, laurent@vivier.eu, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()
Date: Wed, 30 Jan 2019 10:50:18 +0100 [thread overview]
Message-ID: <69177d59-02c9-c6cd-be5a-092bf2476af1@redhat.com> (raw)
In-Reply-To: <20190130000653.16267-2-richardw.yang@linux.intel.com>
On 2019-01-30 01:06, Wei Yang wrote:
> Function pc_acpi_init() is not used anymore.
>
> Remove the definition and declaration.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Reviewed-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daud茅 <philmd@redhat.com>
Hi,
at least in my e-mail client here, it looks like Philippe's last name
got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know.
Same thing also happened in patch 2 and 3.
Apart from that:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-01-30 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 0:06 [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() Wei Yang
2019-01-30 8:10 ` Igor Mammedov
2019-01-30 9:50 ` Thomas Huth [this message]
2019-01-30 11:07 ` Philippe Mathieu-Daudé
2019-01-30 12:58 ` Wei Yang
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin() Wei Yang
2019-01-30 8:11 ` Igor Mammedov
2019-01-30 0:06 ` [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin Wei Yang
2019-01-30 8:11 ` Igor Mammedov
2019-02-12 5:22 ` [Qemu-devel] [PATCH v3 0/3] Trivial cleanup in hw/acpi Wei Yang
2019-02-12 5:34 ` Michael S. Tsirkin
2019-02-13 6:26 ` Wei Yang
2019-02-13 6:32 ` Philippe Mathieu-Daudé
2019-02-13 7:01 ` Wei Yang
2019-02-13 8:49 ` Laurent Vivier
2019-02-13 8:54 ` Wei Yang
2019-02-13 8:56 ` Philippe Mathieu-Daudé
2019-02-13 13:31 ` Wei Yang
2019-02-13 13:45 ` Laurent Vivier
2019-02-14 0:03 ` Wei Yang
2019-02-14 7:57 ` Laurent Vivier
2019-02-14 8:10 ` Laurent Vivier
2019-02-14 8:18 ` Wei Yang
2019-02-14 8:23 ` Laurent Vivier
2019-02-14 8:39 ` Wei Yang
2019-02-14 8:51 ` Wei Yang
2019-02-14 9:11 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69177d59-02c9-c6cd-be5a-092bf2476af1@redhat.com \
--to=thuth@redhat.com \
--cc=imammedo@redhat.com \
--cc=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).