From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gomW5-00072R-4h for qemu-devel@nongnu.org; Wed, 30 Jan 2019 04:50:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gomW1-0008MH-Nu for qemu-devel@nongnu.org; Wed, 30 Jan 2019 04:50:43 -0500 References: <20190130000653.16267-1-richardw.yang@linux.intel.com> <20190130000653.16267-2-richardw.yang@linux.intel.com> From: Thomas Huth Message-ID: <69177d59-02c9-c6cd-be5a-092bf2476af1@redhat.com> Date: Wed, 30 Jan 2019 10:50:18 +0100 MIME-Version: 1.0 In-Reply-To: <20190130000653.16267-2-richardw.yang@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Yang , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, philmd@redhat.com Cc: imammedo@redhat.com, laurent@vivier.eu, mst@redhat.com On 2019-01-30 01:06, Wei Yang wrote: > Function pc_acpi_init() is not used anymore. >=20 > Remove the definition and declaration. >=20 > Signed-off-by: Wei Yang > Reviewed-by: Philippe Mathieu-Daud=E8=8C=85 > Tested-by: Philippe Mathieu-Daud=E8=8C=85 Hi, at least in my e-mail client here, it looks like Philippe's last name got mojibaked here. It should be "Daud=C3=A9", not "Daud=E8=8C=85", as fa= r as I know. Same thing also happened in patch 2 and 3. Apart from that: Reviewed-by: Thomas Huth