From: Richard Henderson <richard.henderson@linaro.org>
To: "Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 1/3] target/arm: Make cpu_register() and set_feature() available for other files
Date: Tue, 3 Sep 2019 09:01:55 -0700 [thread overview]
Message-ID: <69233989-78d6-716f-210a-0372fd4881a0@linaro.org> (raw)
In-Reply-To: <20190903154810.27365-2-thuth@redhat.com>
On 9/3/19 8:48 AM, Thomas Huth wrote:
> Move the common set_feature() and unset_feature() functions from cpu.c and
> cpu64.c to cpu.h, and make cpu_register() (renamed to arm_cpu_register())
> available from there, too, so we can register CPUs also from other files
> in the future.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/arm/cpu.c | 20 ++------------------
> target/arm/cpu.h | 18 ++++++++++++++++++
> target/arm/cpu64.c | 16 ----------------
> 3 files changed, 20 insertions(+), 34 deletions(-)
internals.h would be better, since presumably the uses will not leave target/arm/.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-09-03 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 15:48 [Qemu-devel] [RFC PATCH 0/3] Make it possible to compile with CONFIG_ARM_V7M=n Thomas Huth
2019-09-03 15:48 ` [Qemu-devel] [RFC PATCH 1/3] target/arm: Make cpu_register() and set_feature() available for other files Thomas Huth
2019-09-03 16:01 ` Richard Henderson [this message]
2019-09-03 16:07 ` Peter Maydell
2019-09-03 15:48 ` [Qemu-devel] [RFC PATCH 2/3] target/arm: Move cortex-m related functions to m_helper.c Thomas Huth
2019-09-03 15:48 ` [Qemu-devel] [RFC PATCH 3/3] target/arm: Make m_helper.c optional via CONFIG_ARM_V7M Thomas Huth
2019-09-03 16:19 ` Philippe Mathieu-Daudé
2019-09-03 18:23 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69233989-78d6-716f-210a-0372fd4881a0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).