From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxgZH-0000Rr-Rt for qemu-devel@nongnu.org; Fri, 21 Oct 2016 16:37:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxgZH-0004RD-2n for qemu-devel@nongnu.org; Fri, 21 Oct 2016 16:37:31 -0400 References: <1476247808-15646-1-git-send-email-xiecl.fnst@cn.fujitsu.com> From: Max Reitz Message-ID: <69262a29-424c-bcd5-2b63-f4420a8ef3b4@redhat.com> Date: Fri, 21 Oct 2016 22:37:21 +0200 MIME-Version: 1.0 In-Reply-To: <1476247808-15646-1-git-send-email-xiecl.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="981dxEb1nE8KBf6X7wAtOJS7FHpCjUkXl" Subject: Re: [Qemu-devel] [PATCH v3] block/replication: Clarify 'top-id' parameter usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Changlong Xie , qemu devel , qemu block , Stefan Hajnoczi , Fam Zheng , Kevin Wolf , Eric Blake , Wen Congyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --981dxEb1nE8KBf6X7wAtOJS7FHpCjUkXl From: Max Reitz To: Changlong Xie , qemu devel , qemu block , Stefan Hajnoczi , Fam Zheng , Kevin Wolf , Eric Blake , Wen Congyang Message-ID: <69262a29-424c-bcd5-2b63-f4420a8ef3b4@redhat.com> Subject: Re: [PATCH v3] block/replication: Clarify 'top-id' parameter usage References: <1476247808-15646-1-git-send-email-xiecl.fnst@cn.fujitsu.com> In-Reply-To: <1476247808-15646-1-git-send-email-xiecl.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 12.10.2016 06:50, Changlong Xie wrote: > The replication driver only supports the 'top-id' parameter for the > secondary side; it must not be supplied for the primary side. >=20 > Reviewed-by: Eric Blake > Signed-off-by: Changlong Xie > --- > block/replication.c | 5 +++++ > qapi/block-core.json | 3 ++- > 2 files changed, 7 insertions(+), 1 deletion(-) Thanks, I've applied the patch to my block branch: https://github.com/XanClic/qemu/commits/block Max --981dxEb1nE8KBf6X7wAtOJS7FHpCjUkXl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJYCnyBEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQFwK CACXfQEIN7VZ1RikkDrsKUGPkBDw9MgWmSNTBnNXPEVhXmv3HGxbF7VVUXTLzPcT 9RfArwBXFRwYiyo8rDWdcfUABgMOxxa/3t2qv1/9cJieHshjKe+hcyzCdJjS/FsX gj2ftdg49XT5DCIAzkikAI+m3Y+u6Uay1PiM/KHnhIOI7N6txX1mJhUvFtR43BOv etIsVw6+7oyS4IUH30+bmw9lCHTOeQqXcfPOdwLAuYUd7srxBkQkojaDXjYVR9h5 H8p4FGBTIwMIWd+qVhcNOTmXb/C+6P9Syq9Ga/fDDHRHqDhvRQAy3ZA8kOMfBNUi 8jY01lkAwb6Iypar0Od6RnMh =cJAI -----END PGP SIGNATURE----- --981dxEb1nE8KBf6X7wAtOJS7FHpCjUkXl--