From: Thomas Huth <thuth@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH 1/2] tests: fix "make check-qtest" for modular builds
Date: Mon, 13 Jul 2020 07:36:20 +0200 [thread overview]
Message-ID: <6936f087-35b0-47f0-88f8-aed15582fd43@redhat.com> (raw)
In-Reply-To: <20200710203652.9708-2-kraxel@redhat.com>
On 10/07/2020 22.36, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> tests/qtest/Makefile.include | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/Makefile.include b/tests/qtest/Makefile.include
> index 98af2c2d9338..6a0276fd42dd 100644
> --- a/tests/qtest/Makefile.include
> +++ b/tests/qtest/Makefile.include
> @@ -277,6 +277,7 @@ tests/qtest/tco-test$(EXESUF): tests/qtest/tco-test.o $(libqos-pc-obj-y)
> tests/qtest/virtio-ccw-test$(EXESUF): tests/qtest/virtio-ccw-test.o
> tests/qtest/display-vga-test$(EXESUF): tests/qtest/display-vga-test.o
> tests/qtest/qom-test$(EXESUF): tests/qtest/qom-test.o
> +tests/qtest/modules-test$(EXESUF): tests/qtest/modules-test.o
> tests/qtest/test-hmp$(EXESUF): tests/qtest/test-hmp.o
> tests/qtest/machine-none-test$(EXESUF): tests/qtest/machine-none-test.o
> tests/qtest/device-plug-test$(EXESUF): tests/qtest/device-plug-test.o
What was the error that you run into here? ... some words in the commit
message would be nice. Actually, I always wondered why we need a
separate entry for each and every test here ... I'd rather expect that
this is handled by a normal generic make rule instead?
Thomas
next prev parent reply other threads:[~2020-07-13 5:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 20:36 [PATCH 0/2] module fixes Gerd Hoffmann
2020-07-10 20:36 ` [PATCH 1/2] tests: fix "make check-qtest" for modular builds Gerd Hoffmann
2020-07-13 5:36 ` Thomas Huth [this message]
2020-07-13 6:38 ` Gerd Hoffmann
2020-07-10 20:36 ` [PATCH 2/2] Revert "vga: build virtio-gpu as module" Gerd Hoffmann
2020-07-11 8:51 ` [PATCH 0/2] module fixes Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6936f087-35b0-47f0-88f8-aed15582fd43@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).