From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: Will Cohen <wwcohen@gmail.com>
Cc: "qemu Developers" <qemu-devel@nongnu.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>, "Greg Kurz" <groug@kaod.org>,
hi@alyssa.is, "Michael Roitzsch" <reactorcontrol@icloud.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Keno Fischer" <keno@juliacomputing.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH v8 09/11] 9p: darwin: Implement compatibility for mknodat
Date: Fri, 25 Feb 2022 17:44:51 +0100 [thread overview]
Message-ID: <6945668.jiNg9iTkrT@silver> (raw)
In-Reply-To: <CAB26zV2PaeWhq_PkwTjC1XaOXB-cBo4fmPgOnnTsjGLBZbUvLw@mail.gmail.com>
On Freitag, 25. Februar 2022 17:38:51 CET Will Cohen wrote:
> On Fri, Feb 25, 2022 at 11:31 AM Christian Schoenebeck <
>
> qemu_oss@crudebyte.com> wrote:
> > On Freitag, 25. Februar 2022 15:00:40 CET Will Cohen wrote:
> > > On Tue, Feb 22, 2022 at 9:27 AM Christian Schoenebeck
[...]
> > > osdep.h is the wrong place, should it go back to 9p-util, where it lived
> > > before it moved to osdep?
> >
> > The other function Peter wanted out from osdep.h would fall into that
> > category
> > as well. I understand it like "only put things into osdep.h as very last
> > resort". CCing Peter on this. If he doesn't give you green light, or on
> > doubt,
> > then yes please move it from osdep -> 9p-util.
> >
> > Will, are you planning to send a v9 of this series soon? Next week I need
> > to
> > add changes that would collide with these here. So if you intend to send
> > it
> > soon, then I just wait so that we can finally queue these macOS patches
> > here
> > for QEMU 7.0, before I would go along with my changes.
> >
> > Best regards,
> > Christian Schoenebeck
>
> Prepping a v9 now based on all the other changes + the formatting issues.
> I'll send this weekend if that's okay!
Thumbs up! :)
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2022-02-25 16:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 16:50 [PATCH v8 00/11] 9p: Add support for darwin Will Cohen
2022-02-20 16:50 ` [PATCH v8 01/11] 9p: linux: Fix a couple Linux assumptions Will Cohen
2022-02-20 16:50 ` [PATCH v8 02/11] 9p: Rename 9p-util -> 9p-util-linux Will Cohen
2022-02-20 16:50 ` [PATCH v8 03/11] 9p: darwin: Handle struct stat(fs) differences Will Cohen
2022-02-20 16:50 ` [PATCH v8 04/11] 9p: darwin: Handle struct dirent differences Will Cohen
2022-02-20 21:28 ` Christian Schoenebeck
2022-02-20 21:35 ` Will Cohen
2022-02-20 16:50 ` [PATCH v8 05/11] 9p: darwin: Ignore O_{NOATIME, DIRECT} Will Cohen
2022-02-20 16:50 ` [PATCH v8 06/11] 9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX Will Cohen
2022-02-20 16:50 ` [PATCH v8 07/11] 9p: darwin: *xattr_nofollow implementations Will Cohen
2022-02-20 16:50 ` [PATCH v8 08/11] 9p: darwin: Compatibility for f/l*xattr Will Cohen
2022-02-20 16:50 ` [PATCH v8 09/11] 9p: darwin: Implement compatibility for mknodat Will Cohen
2022-02-20 21:51 ` Christian Schoenebeck
2022-02-22 14:27 ` Christian Schoenebeck
2022-02-25 14:00 ` Will Cohen
2022-02-25 16:31 ` Christian Schoenebeck
2022-02-25 16:38 ` Will Cohen
2022-02-25 16:44 ` Christian Schoenebeck [this message]
2022-02-20 16:50 ` [PATCH v8 10/11] 9p: darwin: Adjust assumption on virtio-9p-test Will Cohen
2022-02-20 16:50 ` [PATCH v8 11/11] 9p: darwin: meson: Allow VirtFS on Darwin Will Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6945668.jiNg9iTkrT@silver \
--to=qemu_oss@crudebyte.com \
--cc=f4bug@amsat.org \
--cc=groug@kaod.org \
--cc=hi@alyssa.is \
--cc=keno@juliacomputing.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=reactorcontrol@icloud.com \
--cc=thuth@redhat.com \
--cc=wwcohen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).