From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: David Hildenbrand <david@redhat.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org
Subject: Re: [PATCH 1/4] target/s390x: Remove unused s390_cpu_[un]halt() user stubs
Date: Fri, 11 Jul 2025 10:36:50 +0200 [thread overview]
Message-ID: <696abbcf-7d89-428f-b7dd-9d15cc8bfa5e@redhat.com> (raw)
In-Reply-To: <20250708095746.12697-2-philmd@linaro.org>
On 08/07/2025 11.57, Philippe Mathieu-Daudé wrote:
> Since commit da944885469 ("target/s390x: make helper.c
> sysemu-only") target/s390x/helper.c is only built for
> system mode, so s390_cpu_halt() and s390_cpu_unhalt()
> are never called from user mode.
>
> Fixes: da944885469 ("target/s390x: make helper.c sysemu-only")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/s390x/s390x-internal.h | 10 ----------
> 1 file changed, 10 deletions(-)
There is another call to s390_cpu_unhalt() in target/s390x/tcg/excp_helper.c
but it is protected by an #ifdef ... so this should be fine.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-07-11 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 9:57 [PATCH 0/4] target/s390x: Cleanups around s390_cpu_[un]halt() Philippe Mathieu-Daudé
2025-07-08 9:57 ` [PATCH 1/4] target/s390x: Remove unused s390_cpu_[un]halt() user stubs Philippe Mathieu-Daudé
2025-07-11 8:36 ` Thomas Huth [this message]
2025-07-08 9:57 ` [PATCH 2/4] target/s390x: Expose s390_count_running_cpus() method Philippe Mathieu-Daudé
2025-07-11 8:39 ` Thomas Huth
2025-07-08 9:57 ` [PATCH 3/4] target/s390x: Have s390_cpu_halt() not return anything Philippe Mathieu-Daudé
2025-07-11 8:39 ` Thomas Huth
2025-07-08 9:57 ` [PATCH 4/4] target/s390x: Extract system internal declarations to s390x-internal.h Philippe Mathieu-Daudé
2025-07-11 8:49 ` Thomas Huth
2025-07-11 8:50 ` [PATCH 0/4] target/s390x: Cleanups around s390_cpu_[un]halt() Thomas Huth
2025-07-11 9:21 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696abbcf-7d89-428f-b7dd-9d15cc8bfa5e@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).