From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA69EC4360C for ; Fri, 27 Sep 2019 17:51:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A14D21655 for ; Fri, 27 Sep 2019 17:51:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A14D21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDuOT-0005dB-In for qemu-devel@archiver.kernel.org; Fri, 27 Sep 2019 13:51:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48715) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDtPz-0004rE-8q for qemu-devel@nongnu.org; Fri, 27 Sep 2019 12:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDtPv-0007A2-MB for qemu-devel@nongnu.org; Fri, 27 Sep 2019 12:48:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40848) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDtPV-0004Lk-11; Fri, 27 Sep 2019 12:48:01 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 236C4C0578F8; Fri, 27 Sep 2019 16:47:55 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8710E60BE2; Fri, 27 Sep 2019 16:47:54 +0000 (UTC) Subject: Re: [PATCH 3/4] qemu-iotests: 044: pass is actually a noop, so remove it To: Cleber Rosa , qemu-devel@nongnu.org References: <20190927141728.7137-1-crosa@redhat.com> <20190927141728.7137-4-crosa@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <69741a7b-fd4b-3f94-eb83-a7a147d6d937@redhat.com> Date: Fri, 27 Sep 2019 11:47:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190927141728.7137-4-crosa@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 27 Sep 2019 16:47:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/27/19 9:17 AM, Cleber Rosa wrote: > Signed-off-by: Cleber Rosa > --- > tests/qemu-iotests/044 | 3 --- > 1 file changed, 3 deletions(-) It's useful when there is nothing else, but here we definitely have something else. Reviewed-by: Eric Blake > > diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 > index 05ea1f49c5..eb42df0fe1 100755 > --- a/tests/qemu-iotests/044 > +++ b/tests/qemu-iotests/044 > @@ -105,17 +105,14 @@ class TestRefcountTableGrowth(iotests.QMPTestCase): > def setUp(self): > qemu_img('create', '-f', iotests.imgfmt, '-o', 'cluster_size=512', test_img, '16G') > self.preallocate(test_img) > - pass > > > def tearDown(self): > os.remove(test_img) > - pass > > def test_grow_refcount_table(self): > qemu_io('-c', 'write 3800M 1M', test_img) > qemu_img_verbose('check' , test_img) > - pass > > if __name__ == '__main__': > iotests.main(supported_fmts=['qcow2'], > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org