From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Ilya Leoshkevich <iii@linux.ibm.com>,
qemu-s390x@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
Eric Farman <farman@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] hw/s390x: Include missing 'cpu.h' header
Date: Mon, 25 Mar 2024 12:01:57 +0100 [thread overview]
Message-ID: <697de906-1998-4803-8e4c-b88dcecc32d0@redhat.com> (raw)
In-Reply-To: <20240322162822.7391-1-philmd@linaro.org>
On 22/03/2024 17.28, Philippe Mathieu-Daudé wrote:
> "cpu.h" is implicitly included. Include it explicitly to
> avoid the following error when refactoring headers:
>
> hw/s390x/s390-stattrib.c:86:40: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
> len = sac->peek_stattr(sas, addr / TARGET_PAGE_SIZE, buflen, vals);
> ^
> hw/s390x/s390-stattrib.c:94:58: error: use of undeclared identifier 'TARGET_PAGE_MASK'
> addr / TARGET_PAGE_SIZE, len, addr & ~TARGET_PAGE_MASK);
> ^
> hw/s390x/s390-stattrib.c:224:40: error: use of undeclared identifier 'TARGET_PAGE_BITS'
> qemu_put_be64(f, (start_gfn << TARGET_PAGE_BITS) | STATTR_FLAG_MORE);
> ^
> In file included from hw/s390x/s390-virtio-ccw.c:17:
> hw/s390x/s390-virtio-hcall.h:22:27: error: unknown type name 'CPUS390XState'
> int s390_virtio_hypercall(CPUS390XState *env);
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/s390x/s390-virtio-hcall.h | 2 ++
> hw/s390x/s390-stattrib.c | 1 +
> 2 files changed, 3 insertions(+)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-03-25 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 16:28 [PATCH] hw/s390x: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2024-03-25 11:01 ` Thomas Huth [this message]
2024-03-25 18:23 ` Eric Farman
2024-04-16 13:25 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=697de906-1998-4803-8e4c-b88dcecc32d0@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).