From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: philmd@redhat.com
Subject: Re: [PATCH] memory-device: simplify Makefile.objs conditions
Date: Tue, 22 Oct 2019 08:00:16 +0200 [thread overview]
Message-ID: <69ad3113-8fc5-43c4-e8ac-12582bdeaf80@redhat.com> (raw)
In-Reply-To: <20191021171120.17947-1-pbonzini@redhat.com>
On 21/10/2019 19.11, Paolo Bonzini wrote:
> hw/mem/ is only included if CONFIG_MEM_DEVICE is true, so we need not
> specify the condition again in hw/mem/Makefile.objs.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/mem/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
> index 3e2f7c5ca2..56345befd0 100644
> --- a/hw/mem/Makefile.objs
> +++ b/hw/mem/Makefile.objs
> @@ -1,3 +1,3 @@
> common-obj-$(CONFIG_DIMM) += pc-dimm.o
> -common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o
> +common-obj-y += memory-device.o
> common-obj-$(CONFIG_NVDIMM) += nvdimm.o
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2019-10-22 6:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 17:11 [PATCH] memory-device: simplify Makefile.objs conditions Paolo Bonzini
2019-10-21 17:27 ` Philippe Mathieu-Daudé
2019-10-22 6:00 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69ad3113-8fc5-43c4-e8ac-12582bdeaf80@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).