* [PATCH] memory-device: simplify Makefile.objs conditions
@ 2019-10-21 17:11 Paolo Bonzini
2019-10-21 17:27 ` Philippe Mathieu-Daudé
2019-10-22 6:00 ` Thomas Huth
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-10-21 17:11 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, philmd
hw/mem/ is only included if CONFIG_MEM_DEVICE is true, so we need not
specify the condition again in hw/mem/Makefile.objs.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/mem/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
index 3e2f7c5ca2..56345befd0 100644
--- a/hw/mem/Makefile.objs
+++ b/hw/mem/Makefile.objs
@@ -1,3 +1,3 @@
common-obj-$(CONFIG_DIMM) += pc-dimm.o
-common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o
+common-obj-y += memory-device.o
common-obj-$(CONFIG_NVDIMM) += nvdimm.o
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] memory-device: simplify Makefile.objs conditions
2019-10-21 17:11 [PATCH] memory-device: simplify Makefile.objs conditions Paolo Bonzini
@ 2019-10-21 17:27 ` Philippe Mathieu-Daudé
2019-10-22 6:00 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-21 17:27 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: thuth
On 10/21/19 7:11 PM, Paolo Bonzini wrote:
> hw/mem/ is only included if CONFIG_MEM_DEVICE is true, so we need not
> specify the condition again in hw/mem/Makefile.objs.
Yes, cleaner.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/mem/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
> index 3e2f7c5ca2..56345befd0 100644
> --- a/hw/mem/Makefile.objs
> +++ b/hw/mem/Makefile.objs
> @@ -1,3 +1,3 @@
> common-obj-$(CONFIG_DIMM) += pc-dimm.o
> -common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o
> +common-obj-y += memory-device.o
> common-obj-$(CONFIG_NVDIMM) += nvdimm.o
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] memory-device: simplify Makefile.objs conditions
2019-10-21 17:11 [PATCH] memory-device: simplify Makefile.objs conditions Paolo Bonzini
2019-10-21 17:27 ` Philippe Mathieu-Daudé
@ 2019-10-22 6:00 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-10-22 6:00 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: philmd
On 21/10/2019 19.11, Paolo Bonzini wrote:
> hw/mem/ is only included if CONFIG_MEM_DEVICE is true, so we need not
> specify the condition again in hw/mem/Makefile.objs.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/mem/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
> index 3e2f7c5ca2..56345befd0 100644
> --- a/hw/mem/Makefile.objs
> +++ b/hw/mem/Makefile.objs
> @@ -1,3 +1,3 @@
> common-obj-$(CONFIG_DIMM) += pc-dimm.o
> -common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o
> +common-obj-y += memory-device.o
> common-obj-$(CONFIG_NVDIMM) += nvdimm.o
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-22 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-21 17:11 [PATCH] memory-device: simplify Makefile.objs conditions Paolo Bonzini
2019-10-21 17:27 ` Philippe Mathieu-Daudé
2019-10-22 6:00 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).