From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Cleber Rosa" <crosa@redhat.com>,
"Lukáš Doktor" <ldoktor@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver
Date: Fri, 30 Nov 2018 08:21:02 +0100 [thread overview]
Message-ID: <69af56c7-413d-857f-829b-37d4747d0d96@redhat.com> (raw)
In-Reply-To: <1389c712-2e02-80c0-b9e1-4c45b54d35df@redhat.com>
On 2018-11-29 21:43, Eric Blake wrote:
> On 11/29/18 11:45 AM, Paolo Bonzini wrote:
>> gtester is deprecated by upstream glib and it does not support tests
>> that call g_test_skip in some glib stable releases.
>>
>> glib suggests instead using Automake's TAP support. We do not support
>> Automake, but we can copy the code that beautifies the TAP output and
>> use it. I chose to use the Perl copy rather than the shell/awk one,
>> in order to reuse Perl's TAP parsing package, but I'm open to suggestions
>> about which language to use.
>
> I'm less familiar with the TAP protocol than I'd like to admit, but I
> did find:
>
> https://blog.gtk.org/2018/07/11/news-from-glib-2-58/
>
> which corroborates your claim that switching to Automake's TAP parser is
> indeed a recommended approach to avoid the now-deprecated gtester.
Hmm, do we really have to maintain our own version of a test runner now?
There's already some effort going on to use avocado in "make
check-acceptance" ... maybe we could use avocado as replacement for
gtester, too?
Thomas
next prev parent reply other threads:[~2018-11-30 7:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 17:45 [Qemu-devel] [PATCH for-4.0 0/2] test: replace gtester with a TAP driver Paolo Bonzini
2018-11-29 17:45 ` [Qemu-devel] [PATCH 1/2] test: execute g_test_run when tests are skipped Paolo Bonzini
2018-11-29 20:48 ` Eric Blake
2018-11-30 7:10 ` Thomas Huth
2018-11-29 17:45 ` [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver Paolo Bonzini
2018-11-29 21:06 ` Eric Blake
2018-11-29 22:04 ` Paolo Bonzini
2018-11-30 15:50 ` Daniel P. Berrangé
2018-11-30 16:19 ` Paolo Bonzini
2018-11-29 20:43 ` [Qemu-devel] [PATCH for-4.0 0/2] " Eric Blake
2018-11-30 7:21 ` Thomas Huth [this message]
2018-11-30 9:58 ` Paolo Bonzini
2018-11-30 14:47 ` Cleber Rosa
2018-11-30 15:05 ` Thomas Huth
2018-11-30 9:54 ` Daniel P. Berrangé
2018-11-30 9:56 ` Paolo Bonzini
2018-11-30 10:21 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69af56c7-413d-857f-829b-37d4747d0d96@redhat.com \
--to=thuth@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ldoktor@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).