Re: [PATCH v2 4/4] s390x/pci: add supported DT information to clp response

[Matthew Rosato <mjrosato@linux.ibm.com>]

On 12/3/21 7:48 AM, Pierre Morel wrote:
> 
> 
> On 12/3/21 13:32, Matthew Rosato wrote:
>> The DTSM is a mask that specifies which I/O Address Translation 
>> designation
>> types are supported.  Today QEMU only supports DT=1.
>>
>> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
>> ---
>>   hw/s390x/s390-pci-bus.c         | 1 +
>>   hw/s390x/s390-pci-inst.c        | 1 +
>>   hw/s390x/s390-pci-vfio.c        | 1 +
>>   include/hw/s390x/s390-pci-bus.h | 1 +
>>   include/hw/s390x/s390-pci-clp.h | 3 ++-
>>   5 files changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
>> index 1b51a72838..01b58ebc70 100644
>> --- a/hw/s390x/s390-pci-bus.c
>> +++ b/hw/s390x/s390-pci-bus.c
>> @@ -782,6 +782,7 @@ static void s390_pci_init_default_group(void)
>>       resgrp->i = 128;
>>       resgrp->maxstbl = 128;
>>       resgrp->version = 0;
>> +    resgrp->dtsm = ZPCI_DTSM;
>>   }
>>   static void set_pbdev_info(S390PCIBusDevice *pbdev)
>> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
>> index 07bab85ce5..f3feba5d74 100644
>> --- a/hw/s390x/s390-pci-inst.c
>> +++ b/hw/s390x/s390-pci-inst.c
>> @@ -329,6 +329,7 @@ int clp_service_call(S390CPU *cpu, uint8_t r2, 
>> uintptr_t ra)
>>           stw_p(&resgrp->i, group->zpci_group.i);
>>           stw_p(&resgrp->maxstbl, group->zpci_group.maxstbl);
>>           resgrp->version = group->zpci_group.version;
>> +        resgrp->version = group->zpci_group.dtsm;
> 
> ;) cut and past error
> 
> ...snip...
> 

... And this is why I should not write code first thing in the morning!

Thanks, will send a v3 in a bit.