From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD974C433EF for ; Fri, 3 Dec 2021 12:50:45 +0000 (UTC) Received: from localhost ([::1]:36018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mt81T-0005du-Cg for qemu-devel@archiver.kernel.org; Fri, 03 Dec 2021 07:50:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt7zP-0003v9-7f; Fri, 03 Dec 2021 07:48:39 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:30116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mt7zN-0006Zf-La; Fri, 03 Dec 2021 07:48:34 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B3Ce87t031119; Fri, 3 Dec 2021 12:48:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=s8AwwzO7InLoIgGSCFKvd8PN0B0Pydiq730FGI3NXm4=; b=Kjp68sWs+gGm5aAKBho5WLGto2NcaeoocOjWpg+3cFOip8ZT5cKqzVpSv4qETBja9+nS unfpe4uLxxUGxA4GyPPjckEOTDzNA8Siw4LO1BkplxVcVknUZam/btJcYq4lx06TgFN9 y60JLaseO8pVpAacXl+qB6J4g3g+Kt+vchboX6lM5uFgO3xtFizHGtUHGcLuYMrv9ShK MojSHojqJ4GF+eNUcscii+b1/RlUZhtKwbhYkPJKQpBgBPhtWBuYul7m5QNSL4kxBhzh NjvvtIQ3aKFM9qHKuX73xv4s6rISx6GGkeNEN30s5ynTc42ixgYNAACbxcYcJsAaplz+ BA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3cqgff3r46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Dec 2021 12:48:30 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1B3ChuJa028732; Fri, 3 Dec 2021 12:48:30 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 3cqgff3r3x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Dec 2021 12:48:30 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1B3ClIdc008971; Fri, 3 Dec 2021 12:48:29 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03dal.us.ibm.com with ESMTP id 3ckcae3xuk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Dec 2021 12:48:29 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1B3CmR3242860906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Dec 2021 12:48:27 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 76CF978067; Fri, 3 Dec 2021 12:48:27 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B53978069; Fri, 3 Dec 2021 12:48:26 +0000 (GMT) Received: from [9.211.96.25] (unknown [9.211.96.25]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 3 Dec 2021 12:48:26 +0000 (GMT) Message-ID: <69b4b200-d0e0-3dc6-6b0c-25bd84b1840d@linux.ibm.com> Date: Fri, 3 Dec 2021 07:48:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2 4/4] s390x/pci: add supported DT information to clp response Content-Language: en-US To: Pierre Morel , thuth@redhat.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org References: <20211203123221.420101-1-mjrosato@linux.ibm.com> <20211203123221.420101-5-mjrosato@linux.ibm.com> From: Matthew Rosato In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GWFKkidBg81CvokyGX0AabgsgofeSxui X-Proofpoint-ORIG-GUID: _isB_7O1g0vudGXh0pmRoIRnz_mc8-Dg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2021-12-03_06,2021-12-02_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112030078 Received-SPF: pass client-ip=148.163.156.1; envelope-from=mjrosato@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.938, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farman@linux.ibm.com, david@redhat.com, cohuck@redhat.com, richard.henderson@linaro.org, pasic@linux.ibm.com, borntraeger@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/3/21 7:48 AM, Pierre Morel wrote: > > > On 12/3/21 13:32, Matthew Rosato wrote: >> The DTSM is a mask that specifies which I/O Address Translation >> designation >> types are supported.  Today QEMU only supports DT=1. >> >> Signed-off-by: Matthew Rosato >> --- >>   hw/s390x/s390-pci-bus.c         | 1 + >>   hw/s390x/s390-pci-inst.c        | 1 + >>   hw/s390x/s390-pci-vfio.c        | 1 + >>   include/hw/s390x/s390-pci-bus.h | 1 + >>   include/hw/s390x/s390-pci-clp.h | 3 ++- >>   5 files changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c >> index 1b51a72838..01b58ebc70 100644 >> --- a/hw/s390x/s390-pci-bus.c >> +++ b/hw/s390x/s390-pci-bus.c >> @@ -782,6 +782,7 @@ static void s390_pci_init_default_group(void) >>       resgrp->i = 128; >>       resgrp->maxstbl = 128; >>       resgrp->version = 0; >> +    resgrp->dtsm = ZPCI_DTSM; >>   } >>   static void set_pbdev_info(S390PCIBusDevice *pbdev) >> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c >> index 07bab85ce5..f3feba5d74 100644 >> --- a/hw/s390x/s390-pci-inst.c >> +++ b/hw/s390x/s390-pci-inst.c >> @@ -329,6 +329,7 @@ int clp_service_call(S390CPU *cpu, uint8_t r2, >> uintptr_t ra) >>           stw_p(&resgrp->i, group->zpci_group.i); >>           stw_p(&resgrp->maxstbl, group->zpci_group.maxstbl); >>           resgrp->version = group->zpci_group.version; >> +        resgrp->version = group->zpci_group.dtsm; > > ;) cut and past error > > ...snip... > ... And this is why I should not write code first thing in the morning! Thanks, will send a v3 in a bit.