* [PATCH] meson: install ivshmem-client and ivshmem-server
@ 2020-09-03 15:35 Bruce Rogers
2020-09-03 15:42 ` Marc-André Lureau
2020-09-03 15:44 ` Paolo Bonzini
0 siblings, 2 replies; 13+ messages in thread
From: Bruce Rogers @ 2020-09-03 15:35 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Bruce Rogers, marcandre.lureau
Turn on the meson install flag for these executables
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
contrib/ivshmem-client/meson.build | 2 +-
contrib/ivshmem-server/meson.build | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
index 1b171efb4f..83a559117f 100644
--- a/contrib/ivshmem-client/meson.build
+++ b/contrib/ivshmem-client/meson.build
@@ -1,4 +1,4 @@
executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
dependencies: glib,
build_by_default: targetos == 'linux',
- install: false)
+ install: true)
diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
index 3a53942201..a1c39aa3b3 100644
--- a/contrib/ivshmem-server/meson.build
+++ b/contrib/ivshmem-server/meson.build
@@ -1,4 +1,4 @@
executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
dependencies: [qemuutil, rt],
build_by_default: targetos == 'linux',
- install: false)
+ install: true)
--
2.28.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-03 15:35 [PATCH] meson: install ivshmem-client and ivshmem-server Bruce Rogers
@ 2020-09-03 15:42 ` Marc-André Lureau
2020-09-03 15:44 ` Paolo Bonzini
1 sibling, 0 replies; 13+ messages in thread
From: Marc-André Lureau @ 2020-09-03 15:42 UTC (permalink / raw)
To: Bruce Rogers; +Cc: Bonzini, Paolo, qemu-devel
Hi
On Thu, Sep 3, 2020 at 7:35 PM Bruce Rogers <brogers@suse.com> wrote:
>
> Turn on the meson install flag for these executables
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
I am not sure we want to install binaries that don't even have
maintainers (or am I wrong?).
> ---
> contrib/ivshmem-client/meson.build | 2 +-
> contrib/ivshmem-server/meson.build | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
> index 1b171efb4f..83a559117f 100644
> --- a/contrib/ivshmem-client/meson.build
> +++ b/contrib/ivshmem-client/meson.build
> @@ -1,4 +1,4 @@
> executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
> dependencies: glib,
> build_by_default: targetos == 'linux',
> - install: false)
> + install: true)
> diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
> index 3a53942201..a1c39aa3b3 100644
> --- a/contrib/ivshmem-server/meson.build
> +++ b/contrib/ivshmem-server/meson.build
> @@ -1,4 +1,4 @@
> executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
> dependencies: [qemuutil, rt],
> build_by_default: targetos == 'linux',
> - install: false)
> + install: true)
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-03 15:35 [PATCH] meson: install ivshmem-client and ivshmem-server Bruce Rogers
2020-09-03 15:42 ` Marc-André Lureau
@ 2020-09-03 15:44 ` Paolo Bonzini
2020-09-03 15:49 ` Daniel P. Berrangé
1 sibling, 1 reply; 13+ messages in thread
From: Paolo Bonzini @ 2020-09-03 15:44 UTC (permalink / raw)
To: Bruce Rogers, qemu-devel; +Cc: marcandre.lureau
On 03/09/20 17:35, Bruce Rogers wrote:
> Turn on the meson install flag for these executables
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> contrib/ivshmem-client/meson.build | 2 +-
> contrib/ivshmem-server/meson.build | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
> index 1b171efb4f..83a559117f 100644
> --- a/contrib/ivshmem-client/meson.build
> +++ b/contrib/ivshmem-client/meson.build
> @@ -1,4 +1,4 @@
> executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
> dependencies: glib,
> build_by_default: targetos == 'linux',
> - install: false)
> + install: true)
> diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
> index 3a53942201..a1c39aa3b3 100644
> --- a/contrib/ivshmem-server/meson.build
> +++ b/contrib/ivshmem-server/meson.build
> @@ -1,4 +1,4 @@
> executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
> dependencies: [qemuutil, rt],
> build_by_default: targetos == 'linux',
> - install: false)
> + install: true)
>
They weren't installed before the conversion, were they?
Paolo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-03 15:44 ` Paolo Bonzini
@ 2020-09-03 15:49 ` Daniel P. Berrangé
2020-09-03 16:10 ` Bruce Rogers
2020-09-03 17:55 ` Paolo Bonzini
0 siblings, 2 replies; 13+ messages in thread
From: Daniel P. Berrangé @ 2020-09-03 15:49 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: marcandre.lureau, qemu-devel, Bruce Rogers
On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
> On 03/09/20 17:35, Bruce Rogers wrote:
> > Turn on the meson install flag for these executables
> >
> > Signed-off-by: Bruce Rogers <brogers@suse.com>
> > ---
> > contrib/ivshmem-client/meson.build | 2 +-
> > contrib/ivshmem-server/meson.build | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
> > index 1b171efb4f..83a559117f 100644
> > --- a/contrib/ivshmem-client/meson.build
> > +++ b/contrib/ivshmem-client/meson.build
> > @@ -1,4 +1,4 @@
> > executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
> > dependencies: glib,
> > build_by_default: targetos == 'linux',
> > - install: false)
> > + install: true)
> > diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
> > index 3a53942201..a1c39aa3b3 100644
> > --- a/contrib/ivshmem-server/meson.build
> > +++ b/contrib/ivshmem-server/meson.build
> > @@ -1,4 +1,4 @@
> > executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
> > dependencies: [qemuutil, rt],
> > build_by_default: targetos == 'linux',
> > - install: false)
> > + install: true)
> >
>
> They weren't installed before the conversion, were they?
Unfortunately they were historically installed with --enable-tools.
IMHO nothing in contrib/ should be installed by default. If we consider
something maintained and high enough quality for end users, it should
migrate out of contrib/ into tools/.
vhost-user-gpu and elf2dmp are also both in contrib/ but installed
by default :-(
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-03 15:49 ` Daniel P. Berrangé
@ 2020-09-03 16:10 ` Bruce Rogers
2020-09-03 17:55 ` Paolo Bonzini
1 sibling, 0 replies; 13+ messages in thread
From: Bruce Rogers @ 2020-09-03 16:10 UTC (permalink / raw)
To: Daniel P. Berrangé, Paolo Bonzini; +Cc: marcandre.lureau, qemu-devel
On Thu, 2020-09-03 at 16:49 +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
> > On 03/09/20 17:35, Bruce Rogers wrote:
> > > Turn on the meson install flag for these executables
> > >
> > > Signed-off-by: Bruce Rogers <brogers@suse.com>
> > > ---
> > > contrib/ivshmem-client/meson.build | 2 +-
> > > contrib/ivshmem-server/meson.build | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/contrib/ivshmem-client/meson.build
> > > b/contrib/ivshmem-client/meson.build
> > > index 1b171efb4f..83a559117f 100644
> > > --- a/contrib/ivshmem-client/meson.build
> > > +++ b/contrib/ivshmem-client/meson.build
> > > @@ -1,4 +1,4 @@
> > > executable('ivshmem-client', files('ivshmem-client.c',
> > > 'main.c'),
> > > dependencies: glib,
> > > build_by_default: targetos == 'linux',
> > > - install: false)
> > > + install: true)
> > > diff --git a/contrib/ivshmem-server/meson.build
> > > b/contrib/ivshmem-server/meson.build
> > > index 3a53942201..a1c39aa3b3 100644
> > > --- a/contrib/ivshmem-server/meson.build
> > > +++ b/contrib/ivshmem-server/meson.build
> > > @@ -1,4 +1,4 @@
> > > executable('ivshmem-server', files('ivshmem-server.c',
> > > 'main.c'),
> > > dependencies: [qemuutil, rt],
> > > build_by_default: targetos == 'linux',
> > > - install: false)
> > > + install: true)
> > >
> >
> > They weren't installed before the conversion, were they?
>
> Unfortunately they were historically installed with --enable-tools.
>
Yeah, that's how I was getting them installed in what we are packaging
up.
- Bruce
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-03 15:49 ` Daniel P. Berrangé
2020-09-03 16:10 ` Bruce Rogers
@ 2020-09-03 17:55 ` Paolo Bonzini
2020-09-04 7:24 ` Markus Armbruster
1 sibling, 1 reply; 13+ messages in thread
From: Paolo Bonzini @ 2020-09-03 17:55 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: marcandre.lureau, qemu-devel, Bruce Rogers
On 03/09/20 17:49, Daniel P. Berrangé wrote:
> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
>> On 03/09/20 17:35, Bruce Rogers wrote:
>>> Turn on the meson install flag for these executables
>>>
>>> Signed-off-by: Bruce Rogers <brogers@suse.com>
>>> ---
>>> contrib/ivshmem-client/meson.build | 2 +-
>>> contrib/ivshmem-server/meson.build | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
>>> index 1b171efb4f..83a559117f 100644
>>> --- a/contrib/ivshmem-client/meson.build
>>> +++ b/contrib/ivshmem-client/meson.build
>>> @@ -1,4 +1,4 @@
>>> executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
>>> dependencies: glib,
>>> build_by_default: targetos == 'linux',
>>> - install: false)
>>> + install: true)
>>> diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
>>> index 3a53942201..a1c39aa3b3 100644
>>> --- a/contrib/ivshmem-server/meson.build
>>> +++ b/contrib/ivshmem-server/meson.build
>>> @@ -1,4 +1,4 @@
>>> executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
>>> dependencies: [qemuutil, rt],
>>> build_by_default: targetos == 'linux',
>>> - install: false)
>>> + install: true)
>>>
>>
>> They weren't installed before the conversion, were they?
>
> Unfortunately they were historically installed with --enable-tools.
>
> IMHO nothing in contrib/ should be installed by default. If we consider
> something maintained and high enough quality for end users, it should
> migrate out of contrib/ into tools/.
Ah, via the tools variable in configure. Nice maze. I've queued the patch.
Paolo
> vhost-user-gpu and elf2dmp are also both in contrib/ but installed
> by default :-(
>
>
> Regards,
> Daniel
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-03 17:55 ` Paolo Bonzini
@ 2020-09-04 7:24 ` Markus Armbruster
2020-09-04 7:57 ` Paolo Bonzini
2020-09-04 9:37 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 13+ messages in thread
From: Markus Armbruster @ 2020-09-04 7:24 UTC (permalink / raw)
To: Paolo Bonzini
Cc: marcandre.lureau, Daniel P. Berrangé, qemu-devel,
Bruce Rogers
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 03/09/20 17:49, Daniel P. Berrangé wrote:
>> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
>>> On 03/09/20 17:35, Bruce Rogers wrote:
>>>> Turn on the meson install flag for these executables
>>>>
>>>> Signed-off-by: Bruce Rogers <brogers@suse.com>
>>>> ---
>>>> contrib/ivshmem-client/meson.build | 2 +-
>>>> contrib/ivshmem-server/meson.build | 2 +-
>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
>>>> index 1b171efb4f..83a559117f 100644
>>>> --- a/contrib/ivshmem-client/meson.build
>>>> +++ b/contrib/ivshmem-client/meson.build
>>>> @@ -1,4 +1,4 @@
>>>> executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
>>>> dependencies: glib,
>>>> build_by_default: targetos == 'linux',
>>>> - install: false)
>>>> + install: true)
>>>> diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
>>>> index 3a53942201..a1c39aa3b3 100644
>>>> --- a/contrib/ivshmem-server/meson.build
>>>> +++ b/contrib/ivshmem-server/meson.build
>>>> @@ -1,4 +1,4 @@
>>>> executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
>>>> dependencies: [qemuutil, rt],
>>>> build_by_default: targetos == 'linux',
>>>> - install: false)
>>>> + install: true)
>>>>
>>>
>>> They weren't installed before the conversion, were they?
>>
>> Unfortunately they were historically installed with --enable-tools.
>>
>> IMHO nothing in contrib/ should be installed by default. If we consider
>> something maintained and high enough quality for end users, it should
>> migrate out of contrib/ into tools/.
>
> Ah, via the tools variable in configure. Nice maze. I've queued the patch.
Please don't.
These programs are examples to help people understand how the ivhsmem
device works. They might even be useful for debugging. They are *not*
to be used in production.
docs/specs/ivshmem-spec.txt:
Example server code is in contrib/ivshmem-server/. Not to be used in
production. It assumes all clients use the same number of interrupt
vectors.
A standalone client is in contrib/ivshmem-client/. It can be useful
for debugging.
Installing example *source* might make sense (but I doubt it).
Installing the binaries does not.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-04 7:24 ` Markus Armbruster
@ 2020-09-04 7:57 ` Paolo Bonzini
2020-09-04 9:20 ` Markus Armbruster
2020-09-04 9:37 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 13+ messages in thread
From: Paolo Bonzini @ 2020-09-04 7:57 UTC (permalink / raw)
To: Markus Armbruster
Cc: marcandre.lureau, Daniel P. Berrangé, qemu-devel,
Bruce Rogers
On 04/09/20 09:24, Markus Armbruster wrote:
>> Ah, via the tools variable in configure. Nice maze. I've queued the patch.
> Please don't.
>
> These programs are examples to help people understand how the ivhsmem
> device works. They might even be useful for debugging. They are *not*
> to be used in production.
Oooookay. :) It needs to be documented in the changelog.
Paolo
> docs/specs/ivshmem-spec.txt:
>
> Example server code is in contrib/ivshmem-server/. Not to be used in
> production. It assumes all clients use the same number of interrupt
> vectors.
>
> A standalone client is in contrib/ivshmem-client/. It can be useful
> for debugging.
>
> Installing example *source* might make sense (but I doubt it).
> Installing the binaries does not.
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-04 7:57 ` Paolo Bonzini
@ 2020-09-04 9:20 ` Markus Armbruster
2020-09-04 11:49 ` Bruce Rogers
0 siblings, 1 reply; 13+ messages in thread
From: Markus Armbruster @ 2020-09-04 9:20 UTC (permalink / raw)
To: Paolo Bonzini
Cc: marcandre.lureau, Daniel P. Berrangé, qemu-devel,
Bruce Rogers
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 04/09/20 09:24, Markus Armbruster wrote:
>>> Ah, via the tools variable in configure. Nice maze. I've queued the patch.
>> Please don't.
>>
>> These programs are examples to help people understand how the ivhsmem
>> device works. They might even be useful for debugging. They are *not*
>> to be used in production.
>
> Oooookay. :) It needs to be documented in the changelog.
I'll take care of updating <https://wiki.qemu.org/ChangeLog/5.2>.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-04 7:24 ` Markus Armbruster
2020-09-04 7:57 ` Paolo Bonzini
@ 2020-09-04 9:37 ` Philippe Mathieu-Daudé
2020-09-04 10:27 ` Daniel P. Berrangé
1 sibling, 1 reply; 13+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-04 9:37 UTC (permalink / raw)
To: Markus Armbruster, Paolo Bonzini
Cc: marcandre.lureau, Daniel P. Berrangé, qemu-devel,
Bruce Rogers
On 9/4/20 9:24 AM, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> On 03/09/20 17:49, Daniel P. Berrangé wrote:
>>> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
>>>> On 03/09/20 17:35, Bruce Rogers wrote:
>>>>> Turn on the meson install flag for these executables
>>>>>
>>>>> Signed-off-by: Bruce Rogers <brogers@suse.com>
>>>>> ---
>>>>> contrib/ivshmem-client/meson.build | 2 +-
>>>>> contrib/ivshmem-server/meson.build | 2 +-
>>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
>>>>> index 1b171efb4f..83a559117f 100644
>>>>> --- a/contrib/ivshmem-client/meson.build
>>>>> +++ b/contrib/ivshmem-client/meson.build
>>>>> @@ -1,4 +1,4 @@
>>>>> executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
>>>>> dependencies: glib,
>>>>> build_by_default: targetos == 'linux',
>>>>> - install: false)
>>>>> + install: true)
>>>>> diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
>>>>> index 3a53942201..a1c39aa3b3 100644
>>>>> --- a/contrib/ivshmem-server/meson.build
>>>>> +++ b/contrib/ivshmem-server/meson.build
>>>>> @@ -1,4 +1,4 @@
>>>>> executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
>>>>> dependencies: [qemuutil, rt],
>>>>> build_by_default: targetos == 'linux',
>>>>> - install: false)
>>>>> + install: true)
>>>>>
>>>>
>>>> They weren't installed before the conversion, were they?
>>>
>>> Unfortunately they were historically installed with --enable-tools.
>>>
>>> IMHO nothing in contrib/ should be installed by default. If we consider
>>> something maintained and high enough quality for end users, it should
>>> migrate out of contrib/ into tools/.
>>
>> Ah, via the tools variable in configure. Nice maze. I've queued the patch.
>
> Please don't.
>
> These programs are examples to help people understand how the ivhsmem
> device works. They might even be useful for debugging. They are *not*
> to be used in production.
>
> docs/specs/ivshmem-spec.txt:
>
> Example server code is in contrib/ivshmem-server/. Not to be used in
> production. It assumes all clients use the same number of interrupt
> vectors.
>
> A standalone client is in contrib/ivshmem-client/. It can be useful
> for debugging.
Renaming the file names to contain "example" would make this clear.
>
> Installing example *source* might make sense (but I doubt it).
> Installing the binaries does not.
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-04 9:37 ` Philippe Mathieu-Daudé
@ 2020-09-04 10:27 ` Daniel P. Berrangé
0 siblings, 0 replies; 13+ messages in thread
From: Daniel P. Berrangé @ 2020-09-04 10:27 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel, Paolo Bonzini, Bruce Rogers, Markus Armbruster,
marcandre.lureau
On Fri, Sep 04, 2020 at 11:37:58AM +0200, Philippe Mathieu-Daudé wrote:
> On 9/4/20 9:24 AM, Markus Armbruster wrote:
> > Paolo Bonzini <pbonzini@redhat.com> writes:
> >
> >> On 03/09/20 17:49, Daniel P. Berrangé wrote:
> >>> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote:
> >>>> On 03/09/20 17:35, Bruce Rogers wrote:
> >>>>> Turn on the meson install flag for these executables
> >>>>>
> >>>>> Signed-off-by: Bruce Rogers <brogers@suse.com>
> >>>>> ---
> >>>>> contrib/ivshmem-client/meson.build | 2 +-
> >>>>> contrib/ivshmem-server/meson.build | 2 +-
> >>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
> >>>>> index 1b171efb4f..83a559117f 100644
> >>>>> --- a/contrib/ivshmem-client/meson.build
> >>>>> +++ b/contrib/ivshmem-client/meson.build
> >>>>> @@ -1,4 +1,4 @@
> >>>>> executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
> >>>>> dependencies: glib,
> >>>>> build_by_default: targetos == 'linux',
> >>>>> - install: false)
> >>>>> + install: true)
> >>>>> diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
> >>>>> index 3a53942201..a1c39aa3b3 100644
> >>>>> --- a/contrib/ivshmem-server/meson.build
> >>>>> +++ b/contrib/ivshmem-server/meson.build
> >>>>> @@ -1,4 +1,4 @@
> >>>>> executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
> >>>>> dependencies: [qemuutil, rt],
> >>>>> build_by_default: targetos == 'linux',
> >>>>> - install: false)
> >>>>> + install: true)
> >>>>>
> >>>>
> >>>> They weren't installed before the conversion, were they?
> >>>
> >>> Unfortunately they were historically installed with --enable-tools.
> >>>
> >>> IMHO nothing in contrib/ should be installed by default. If we consider
> >>> something maintained and high enough quality for end users, it should
> >>> migrate out of contrib/ into tools/.
> >>
> >> Ah, via the tools variable in configure. Nice maze. I've queued the patch.
> >
> > Please don't.
> >
> > These programs are examples to help people understand how the ivhsmem
> > device works. They might even be useful for debugging. They are *not*
> > to be used in production.
> >
> > docs/specs/ivshmem-spec.txt:
> >
> > Example server code is in contrib/ivshmem-server/. Not to be used in
> > production. It assumes all clients use the same number of interrupt
> > vectors.
> >
> > A standalone client is in contrib/ivshmem-client/. It can be useful
> > for debugging.
>
> Renaming the file names to contain "example" would make this clear.
That's essentially what 'contrib' already means. We shold probablt
add a contrib/README.rst file though to explicitly tell people what
we consider the state of these things to be.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-04 9:20 ` Markus Armbruster
@ 2020-09-04 11:49 ` Bruce Rogers
2020-09-04 13:39 ` Markus Armbruster
0 siblings, 1 reply; 13+ messages in thread
From: Bruce Rogers @ 2020-09-04 11:49 UTC (permalink / raw)
To: Markus Armbruster, Paolo Bonzini
Cc: marcandre.lureau, Daniel P.Berrangé, qemu-devel
On Fri, 2020-09-04 at 11:20 +0200, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > On 04/09/20 09:24, Markus Armbruster wrote:
> > > > Ah, via the tools variable in configure. Nice maze. I've
> > > > queued the patch.
> > > Please don't.
> > >
> > > These programs are examples to help people understand how the
> > > ivhsmem
> > > device works. They might even be useful for debugging. They are
> > > *not*
> > > to be used in production.
> >
> > Oooookay. :) It needs to be documented in the changelog.
>
> I'll take care of updating <https://wiki.qemu.org/ChangeLog/5.2>;.
>
Thanks all for the clarification on this one. It was packaged up simply
because it got installed, and I never got to looking at the use case
for these binaries.
I'll remove them from what we package in SUSE's SLE and openSUSE.
- Bruce
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] meson: install ivshmem-client and ivshmem-server
2020-09-04 11:49 ` Bruce Rogers
@ 2020-09-04 13:39 ` Markus Armbruster
0 siblings, 0 replies; 13+ messages in thread
From: Markus Armbruster @ 2020-09-04 13:39 UTC (permalink / raw)
To: Bruce Rogers
Cc: Paolo Bonzini, Daniel P.Berrangé, qemu-devel,
marcandre.lureau
Bruce Rogers <brogers@suse.com> writes:
> On Fri, 2020-09-04 at 11:20 +0200, Markus Armbruster wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>> > On 04/09/20 09:24, Markus Armbruster wrote:
>> > > > Ah, via the tools variable in configure. Nice maze. I've
>> > > > queued the patch.
>> > > Please don't.
>> > >
>> > > These programs are examples to help people understand how the
>> > > ivhsmem
>> > > device works. They might even be useful for debugging. They are
>> > > *not*
>> > > to be used in production.
>> >
>> > Oooookay. :) It needs to be documented in the changelog.
>>
>> I'll take care of updating <https://wiki.qemu.org/ChangeLog/5.2>;.
>>
>
> Thanks all for the clarification on this one. It was packaged up simply
> because it got installed, and I never got to looking at the use case
> for these binaries.
>
> I'll remove them from what we package in SUSE's SLE and openSUSE.
Thanks!
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-09-04 13:40 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-03 15:35 [PATCH] meson: install ivshmem-client and ivshmem-server Bruce Rogers
2020-09-03 15:42 ` Marc-André Lureau
2020-09-03 15:44 ` Paolo Bonzini
2020-09-03 15:49 ` Daniel P. Berrangé
2020-09-03 16:10 ` Bruce Rogers
2020-09-03 17:55 ` Paolo Bonzini
2020-09-04 7:24 ` Markus Armbruster
2020-09-04 7:57 ` Paolo Bonzini
2020-09-04 9:20 ` Markus Armbruster
2020-09-04 11:49 ` Bruce Rogers
2020-09-04 13:39 ` Markus Armbruster
2020-09-04 9:37 ` Philippe Mathieu-Daudé
2020-09-04 10:27 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).