Re: [PATCH 1/3] ui/sdl2: reenable the SDL2 Windows keyboard hook procedure

[Bernhard Beschow <shentey@gmail.com>]

Am 11. September 2024 11:59:25 UTC schrieb "Philippe Mathieu-Daudé" <philmd@linaro.org>:
>On 11/9/24 13:57, Philippe Mathieu-Daudé wrote:
>> Hi Volker,
>> 
>> On 9/9/24 21:38, Volker Rümelin wrote:
>>> Am 09.09.24 um 09:26 schrieb Marc-André Lureau:
>>>> Hi
>>>> 
>>>> On Mon, Sep 9, 2024 at 10:22 AM Volker Rümelin <vr_qemu@t-online.de> wrote:
>>>>> Windows only:
>>>>> 
>>>>> The libSDL2 Windows message loop needs the libSDL2 Windows low
>>>>> level keyboard hook procedure to grab the left and right Windows
>>>>> keys correctly. Reenable the SDL2 Windows keyboard hook procedure.
>>>>> 
>>>>> Because the QEMU Windows keyboard hook procedure is still needed
>>>>> to filter out the special left Control key event for every Alt Gr
>>>>> key event, it's important to install the two keyboard hook
>>>>> procedures in the following order. First the SDL2 procedure, then
>>>>> the QEMU procedure.
>>>>> 
>>>>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2139
>>>>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2323
>>>>> Tested-by: Howard Spoelstra <hsp.cat7@gmail.com>
>>>>> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
>>>>> ---
>>>>>   ui/sdl2.c           | 53 ++++++++++++++++++++++++++++++---------------
>>>>>   ui/win32-kbd-hook.c |  3 +++
>>>>>   2 files changed, 38 insertions(+), 18 deletions(-)
>> 
>> 
>>>> Note: there is no 2.16 release. They jumped from 2.0.22 to 2.24 (see
>>>> https://github.com/libsdl-org/SDL/releases/tag/release-2.24.0)
>>> 
>>> Hi Marc-André
>>> 
>>> Oh. This means that the comparison I wrote is true for SDL2 versions <
>>> 2.24.0.
>>> 
>>>> 
>>>> The windows hook was indeed added in 2.0.16, released on Aug 10, 2021.
>>>> 
>>>> Given the distribution nature of the Windows binaries, I think we
>>>> could simply depend on a much recent version without worrying about
>>>> compatibility with < 2.0.16. This would help reduce the potential
>>>> combinations of versions and bugs reports.
>>> 
>>> Okay, I'll send a version 2 patch series.
>> 
>> Queuing patches 2 & 3 meanwhile. Please do not bury series within
>> threads, if Bernhard hadn't sent his T-b tag, I'd have missed it.
>
>Oh actually this is a series with a cover, but the cover subject
>doesn't contains 'PATCH' which is why my git tool missed it.
>

For me, `git am` didn't work after downloading the series' mbox. I had to download each patch mail individually and apply one by one. Then I could test the series.