qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Ashish Kalra <ashish.kalra@amd.com>
Cc: thomas.lendacky@amd.com, jon.grimm@amd.com,
	brijesh.singh@amd.com, dgilbert@redhat.com,
	qemu-devel@nongnu.org
Subject: Re: SEV guest debugging support for Qemu
Date: Sat, 26 Sep 2020 02:02:20 +0200	[thread overview]
Message-ID: <6a0188c5-8dbc-e86c-6726-ba7bfb821697@redhat.com> (raw)
In-Reply-To: <20200925234841.GA11103@ashkalra_ubuntu_server>

On 26/09/20 01:48, Ashish Kalra wrote:
> Thanks for your input, i have one additional query with reference to this support :
> 
> For all explicitly unecrypted guest memory regions such as S/W IOTLB bounce buffers,
> dma_decrypted() allocated regions and for guest regions marked as "__bss_decrypted",
> we need to ensure that DBG_DECRYPT API calls are bypassed for such
> regions and those regions are dumped as un-encrypted.

Yes those would be a bit different as they would be physical memory
accesses.  Those currently go through address_space_read in memory_dump
(monitor/misc.c), and would have to use the MemoryDebugOps instead.
That is the place to hook into in order to read the KVM page encryption
bitmap (which is not per-CPU, so another MemoryDebugOps entry
get_phys_addr_attrs?); the MemTxAttrs can then be passed to the read
function in the MemoryDebugOps.

> This guest memory regions encryption status is found using KVM's page encryption bitmap
> support which is part of the page encryption bitmap hypercall interface of the
> KVM/QEMU SEV live migration patches.
> 
> As this additional debug support is dependent on the KVM's page encryption bitmap
> support, are there any updates on KVM SEV live migration patches ?

Sorry about that, I've been busy with QEMU.  I'll review them as soon as
possible.

Paolo



  reply	other threads:[~2020-09-26  0:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 20:11 SEV guest debugging support for Qemu Ashish Kalra
2020-09-24 13:53 ` Dr. David Alan Gilbert
2020-09-24 19:06   ` Ashish Kalra
2020-09-24 19:37     ` Brijesh Singh
2020-09-24 21:52       ` Ashish Kalra
2020-09-25  8:39         ` Dr. David Alan Gilbert
2020-09-25  8:51 ` Paolo Bonzini
2020-09-25 20:46   ` Ashish Kalra
2020-09-25 20:56     ` Paolo Bonzini
2020-09-25 23:48       ` Ashish Kalra
2020-09-26  0:02         ` Paolo Bonzini [this message]
2020-09-28 13:26           ` Ashish Kalra
2020-09-28 18:08             ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2020-09-22 19:45 Kalra, Ashish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a0188c5-8dbc-e86c-6726-ba7bfb821697@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ashish.kalra@amd.com \
    --cc=brijesh.singh@amd.com \
    --cc=dgilbert@redhat.com \
    --cc=jon.grimm@amd.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).