Re: [Qemu-devel] [PULL 00/04] seccomp branch queue

Re: [Qemu-devel] [PULL 00/04] seccomp branch queue

[Namsun Ch'o]

> I guess this is addressed to Namsun's patches.

> Namsun, can you rewrite the commit messages according to Peter's
> suggestions and resend?

Sure. I used a longer commit message, and put the chatty stuff below the 
---.
I posted it as a new top-level thread as a v3 patch.

[Qemu-devel] [PULL 00/04] seccomp branch queue

[Eduardo Otubo]

The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100)

are available in the git repository at:

  git://github.com/otubo/qemu.git tags/pull-seccomp-20151015

for you to fetch changes up to d8e4d1ef78093037fc6483561aee3aaedebbaa37:

  Add syscalls for -runas and -chroot to the seccomp sandbox (2015-10-15 09:41:15 +0200)

----------------------------------------------------------------
seccomp branch queue

----------------------------------------------------------------
Andrew Jones (2):
      libseccomp: add cacheflush to whitelist
      configure: arm/aarch64: allow enable-seccomp

Namsun Ch'o (2):
      Add argument filters to the seccomp sandbox
      Add syscalls for -runas and -chroot to the seccomp sandbox

 configure      | 32 +++++++++++++++++++++++++-------
 qemu-seccomp.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 86 insertions(+), 11 deletions(-)

-- 
2.1.4

Re: [Qemu-devel] [PULL 00/04] seccomp branch queue

[Peter Maydell]

On 15 October 2015 at 08:57, Eduardo Otubo
<eduardo.otubo@profitbricks.com> wrote:
> The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100)
>
> are available in the git repository at:
>
>   git://github.com/otubo/qemu.git tags/pull-seccomp-20151015
>
> for you to fetch changes up to d8e4d1ef78093037fc6483561aee3aaedebbaa37:
>
>   Add syscalls for -runas and -chroot to the seccomp sandbox (2015-10-15 09:41:15 +0200)
>
> ----------------------------------------------------------------
> seccomp branch queue
>
> ----------------------------------------------------------------
> Andrew Jones (2):
>       libseccomp: add cacheflush to whitelist
>       configure: arm/aarch64: allow enable-seccomp
>
> Namsun Ch'o (2):
>       Add argument filters to the seccomp sandbox
>       Add syscalls for -runas and -chroot to the seccomp sandbox

The commit messages in this are a bit of a mess. In particular,
there's lots of chatty information about "I compiled QEMU and it worked fine"
and "changes between v2 and v3" information, which should all
go below the '---' divider so it doesn't appear in the final
commit logs. "Add argument filters to the seccomp sandbox" should
really also have a longer and more explanatory commit message
giving rationale for the change, and so on, since it's adding
a fair bit of new code.

Can you either clean them up or ask the submitters to do so,
please?

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/04] seccomp branch queue

[Eduardo Otubo]

[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]

On Fri, Oct 16, 2015 at 05=12=18PM +0100, Peter Maydell wrote:
> On 15 October 2015 at 08:57, Eduardo Otubo
> <eduardo.otubo@profitbricks.com> wrote:
> > The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:
> >
> >   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100)
> >
> > are available in the git repository at:
> >
> >   git://github.com/otubo/qemu.git tags/pull-seccomp-20151015
> >
> > for you to fetch changes up to d8e4d1ef78093037fc6483561aee3aaedebbaa37:
> >
> >   Add syscalls for -runas and -chroot to the seccomp sandbox (2015-10-15 09:41:15 +0200)
> >
> > ----------------------------------------------------------------
> > seccomp branch queue
> >
> > ----------------------------------------------------------------
> > Andrew Jones (2):
> >       libseccomp: add cacheflush to whitelist
> >       configure: arm/aarch64: allow enable-seccomp
> >
> > Namsun Ch'o (2):
> >       Add argument filters to the seccomp sandbox
> >       Add syscalls for -runas and -chroot to the seccomp sandbox
> 
> The commit messages in this are a bit of a mess. In particular,
> there's lots of chatty information about "I compiled QEMU and it worked fine"
> and "changes between v2 and v3" information, which should all
> go below the '---' divider so it doesn't appear in the final
> commit logs. "Add argument filters to the seccomp sandbox" should
> really also have a longer and more explanatory commit message
> giving rationale for the change, and so on, since it's adding
> a fair bit of new code.
> 
> Can you either clean them up or ask the submitters to do so,
> please?

I guess this is addressed to Namsun's patches.

Namsun, can you rewrite the commit messages according to Peter's
suggestions and resend?

Thanks,

> 
> thanks
> -- PMM

-- 
Eduardo Otubo
ProfitBricks GmbH

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[Qemu-devel] [PULL 00/04] seccomp branch queue

[Eduardo Otubo]

The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' into staging (2015-10-13 10:42:06 +0100)

are available in the git repository at:

  git://github.com/otubo/qemu.git tags/pull-seccomp-20151014

for you to fetch changes up to dcebff271f7134265e8c627088ccab86bfcd4867:

  Add syscalls for -runas and -chroot to the seccomp sandbox (2015-10-14 11:08:46 +0200)

----------------------------------------------------------------
seccomp branch queue

----------------------------------------------------------------
Andrew Jones (2):
      libseccomp: add cacheflush to whitelist
      configure: arm/aarch64: allow enable-seccomp

Namsun Ch'o (2):
      Add argument filters to the seccomp sandbox
      Add syscalls for -runas and -chroot to the seccomp sandbox

 configure      | 32 +++++++++++++++++++++++++-------
 qemu-seccomp.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 87 insertions(+), 11 deletions(-)


-- 
2.1.4