qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: minimal "zero conf" build dockerfiles for fedora:latest and alpine:latest
Date: Wed, 13 Jan 2021 09:26:50 +0100	[thread overview]
Message-ID: <6a08e9f5-7cd7-c2c8-4b61-5466a4ffb2ec@redhat.com> (raw)
In-Reply-To: <a56f2df6-867e-2542-734c-95c1ae3acf88@redhat.com>

On 13/01/21 07:48, Thomas Huth wrote:
>>
>> [254/8314] Generating texture-blit-frag.h with a meson_exe.py custom 
>> command
>> FAILED: ui/shader/texture-blit-frag.h
>> /usr/bin/python3 /qemu-5.2.0/meson/meson.py --internal exe --capture 
>> ui/shader/texture-blit-frag.h -- /usr/bin/env perl 
>> /qemu-5.2.0/scripts/shaderinclude.pl ../ui/shader/texture-blit.frag
>> /usr/bin/env: ‘perl’: No such file or directory
> 
> shaderinclude.pl seems to be pretty small, maybe it could be rewritten 
> in python?

Probably, but "make check" also requires Perl for the TAP driver.  I do 
have plans for using "meson test" instead, *however* there's also the 
other idea I've floated of parsing the command line with Perl:

https://patchew.org/QEMU/20210107140039.467969-1-pbonzini@redhat.com/20210107140039.467969-9-pbonzini@redhat.com/

(reviews welcome by the way).

I don't like Perl really, but there's a chicken-and-egg problem between 
detecting Python and using it to print the configure help script.  For 
configure-time tasks, Perl has the advantage that "#! /usr/bin/env perl" 
just works.

>> - bash has to be installed explicitly. configure/meson do not check 
>> for it, but the build will fail if they aren't present.
> 
> IIRC we were able to compile without bash before the meson conversion, 
> just some parts like the iotests needed the bash (at least that's why we 
> have a check for bash in tests/check-block.sh for example). Where is it 
> failing now?

It's failing due to

SHELL = /usr/bin/env bash -o pipefail

introduced in 5.2 (but not related to the Meson conversion)

     commit 3bf4583580ab705de1beff6222e934239c3a0356
     Author: Paolo Bonzini <pbonzini@redhat.com>
     Date:   Wed Oct 14 07:35:13 2020 -0400

     make: run shell with pipefail

     Without pipefail, it is possible to miss failures if the recipes
     include pipes.

     Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo



  reply	other threads:[~2021-01-13  8:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 22:37 minimal "zero conf" build dockerfiles for fedora:latest and alpine:latest John Snow
2021-01-13  6:48 ` Thomas Huth
2021-01-13  8:26   ` Paolo Bonzini [this message]
2021-01-13 10:09     ` Gerd Hoffmann
2021-01-13 10:29       ` Philippe Mathieu-Daudé
2021-01-13 14:35         ` Paolo Bonzini
2021-01-13 18:31       ` John Snow
2021-01-14 11:10         ` Andrea Bolognani
2021-01-14 16:13           ` John Snow
2021-01-13 18:27   ` John Snow
2021-01-13  8:20 ` Paolo Bonzini
2021-01-13 18:44   ` John Snow
2021-01-14 16:51   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a08e9f5-7cd7-c2c8-4b61-5466a4ffb2ec@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=jsnow@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).