From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34792)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@sebastianbauer.info>) id 1faoHP-000308-C0
	for qemu-devel@nongnu.org; Wed, 04 Jul 2018 16:21:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@sebastianbauer.info>) id 1faoHL-0004jx-Cq
	for qemu-devel@nongnu.org; Wed, 04 Jul 2018 16:21:35 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 04 Jul 2018 22:21:19 +0200
From: Sebastian Bauer <mail@sebastianbauer.info>
In-Reply-To: <20180704185321.GZ7451@localhost.localdomain>
References: <20180704112859.20146-1-kraxel@redhat.com>
	<20180704185321.GZ7451@localhost.localdomain>
Message-ID: <6a0aba7b46b168360fb291eaec769eb0@sebastianbauer.info>
Subject: Re: [Qemu-devel] [PATCH] vga: make stdvga the global default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Alexander Graf <agraf@suse.de>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Aleksandar Markovic <aleksandar.markovic@mips.com>, Aurelien Jarno <aurelien@aurel32.net>, "Michael S. Tsirkin" <mst@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, BALATON Zoltan <balaton@eik.bme.hu>, qemu-ppc@nongnu.org, Richard Henderson <rth@twiddle.net>

Am 2018-07-04 20:53, schrieb Eduardo Habkost:
>>      mc->kvm_type = spapr_kvm_type;
>>      machine_class_allow_dynamic_sysbus_dev(mc, 
>> TYPE_SPAPR_PCI_HOST_BRIDGE);
>>      mc->pci_allow_0_address = true;
>> diff --git a/vl.c b/vl.c
>> index 16b913f9d5..e60bf2d6cd 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -4475,10 +4475,10 @@ int main(int argc, char **argv, char **envp)
>>      if (default_vga) {
>>          if (machine_class->default_display) {
>>              vga_model = machine_class->default_display;
>> -        } else if (vga_interface_available(VGA_CIRRUS)) {
>> -            vga_model = "cirrus";
>>          } else if (vga_interface_available(VGA_STD)) {
>>              vga_model = "std";
>> +        } else if (vga_interface_available(VGA_CIRRUS)) {
>> +            vga_model = "cirrus";
> 
> If we don't make the machines above have default_display=NULL, we
> won't need this hunk, right?  In either case, I suggest doing
> this change on a separate patch.

An alternative would be to define the default always to VGA_STD if the 
machine does not override it. This is from the observation that the 
majority would chose std. Obviously, having default values always has 
pro and cons. I would not consider it harmful here.

Is there any configuration that includes VGA_CIRRUS but not VGA_STD?

Bye
Sebastian