Re: [PATCH 03/16] include: move target_words_bigendian() from tswap to bswap

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 3/10/25 08:21, Richard Henderson wrote:
> On 3/9/25 21:58, Pierrick Bouvier wrote:
>> This is needed for next commits (especially when implementing st/ld
>> primitives which will use this function).
>> As well, remove reference to TARGET_BIG_ENDIAN, as we are about to
>> remove this dependency.
> 
> Where is the TARGET_BIG_ENDIAN reference being removed?
> 

The comment part removed, during the move, is:
"Note that in target-specific code, you can use
  TARGET_BIG_ENDIAN directly instead."

>> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
>> index b915835bead..ebf6f9e5f5c 100644
>> --- a/include/qemu/bswap.h
>> +++ b/include/qemu/bswap.h
>> @@ -1,6 +1,8 @@
>>    #ifndef BSWAP_H
>>    #define BSWAP_H
>>    
>> +#include <stdbool.h>
> 
> You shouldn't need this.  It is included by osdep.h, for every file.
> 

I'll take a look at that.

> 
> r~