From: Richard Henderson <richard.henderson@linaro.org>
To: Sven Schnelle <svens@stackframe.org>
Cc: qemu-devel@nongnu.org, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH v2 3/6] target/hppa: fix access_id check
Date: Tue, 19 Mar 2024 08:35:10 -1000 [thread overview]
Message-ID: <6a363223-384c-4480-8bf3-2cb7160a68b5@linaro.org> (raw)
In-Reply-To: <20240319161921.487080-4-svens@stackframe.org>
On 3/19/24 06:19, Sven Schnelle wrote:
> PA2.0 provides 8 instead of 4 PID registers.
>
> Signed-off-by: Sven Schnelle <svens@stackframe.org>
> ---
> target/hppa/mem_helper.c | 59 +++++++++++++++++++++++++++++++++-------
> 1 file changed, 49 insertions(+), 10 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> +/* Return the set of protections allowed by a PID match. */
> +static int match_prot_id_1(uint32_t access_id, uint32_t prot_id)
> +{
> + if (((access_id ^ (prot_id >> 1)) & ACCESS_ID_MASK) == 0) {
> + return (prot_id & 1
> + ? PROT_EXEC | PROT_READ
> + : PROT_EXEC | PROT_READ | PROT_WRITE);
Tabs? Anyway, weird indentation...
r~
next prev parent reply other threads:[~2024-03-19 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 16:19 [PATCH v2 0/6] few fixes for hppa target Sven Schnelle
2024-03-19 16:19 ` [PATCH v2 1/6] target/hppa: ldcw,s uses static shift of 3 Sven Schnelle
2024-03-19 16:19 ` [PATCH v2 2/6] target/hppa: fix shrp for wide mode Sven Schnelle
2024-03-19 16:19 ` [PATCH v2 3/6] target/hppa: fix access_id check Sven Schnelle
2024-03-19 18:35 ` Richard Henderson [this message]
2024-03-19 16:19 ` [PATCH v2 4/6] target/hppa: exit tb on flush cache instructions Sven Schnelle
2024-03-19 16:19 ` [PATCH v2 5/6] target/hppa: mask privilege bits in mfia Sven Schnelle
2024-03-19 16:19 ` [PATCH v2 6/6] target/hppa: fix do_stdby_e() Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a363223-384c-4480-8bf3-2cb7160a68b5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).