From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY
Date: Tue, 1 May 2018 18:29:52 -0500 [thread overview]
Message-ID: <6a375bc6-12c8-648b-288b-d256ab040825@redhat.com> (raw)
In-Reply-To: <20180501220509.14152-1-mreitz@redhat.com>
On 05/01/2018 05:05 PM, Max Reitz wrote:
> Currently, you cannot cancel a mirror job without the @force flag set.
> This is intentional once source and target are in sync, but probably not
> so much before that happens. The main reason for me thinking this is
> because it is an undocumented change in 2.12.0 in respect to 2.11.
Yeah, that definitely feels like a regression worth fixing.
>
> (b76e4458b1eb3c32e9824fe6aa51f67d2b251748 only notes a behavior change
> after READY, but not before.)
>
>
> This series depends on Stefan’s patch “block/mirror: honor ratelimit
> again” (which is in Jeff’s queue).
>
> Based-on: <20180424123527.19168-1-stefanha@redhat.com>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-01 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 22:05 [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY Max Reitz
2018-05-01 22:05 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2018-05-01 23:31 ` Eric Blake
2018-05-02 12:35 ` Max Reitz
2018-05-01 22:05 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for cancelling a mirror job Max Reitz
2018-05-02 14:31 ` Jeff Cody
2018-05-01 23:29 ` Eric Blake [this message]
2018-05-02 14:32 ` [Qemu-devel] [PATCH 0/2] block/mirror: Make cancel always cancel pre-READY Jeff Cody
2018-05-02 17:36 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a375bc6-12c8-648b-288b-d256ab040825@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).