From: Eric Blake <eblake@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>,
qemu-devel <qemu-devel@nongnu.org>
Cc: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4 3/4] block: remove bdrv_truncate callback in blkdebug
Date: Tue, 11 Jul 2017 13:20:24 -0500 [thread overview]
Message-ID: <6a647abd-dfa0-4ef4-bfba-613e4f1392bd@redhat.com> (raw)
In-Reply-To: <20170711163748.17817-4-el13635@mail.ntua.gr>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote:
> Now that bdrv_truncate is passed to bs->file by default, remove the
> callback from block/blkdebug.c and set is_filter to true.
This also automatically gives blkdebug access to
bdrv_probe_blocksizes
bdrv_probe_geometry
bdrv_has_zero_init
bdrv_get_info
all of which make sense to me.
>
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
> ---
> block/blkdebug.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-07-11 18:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 16:37 [Qemu-devel] [PATCH v4 0/4] block: Block driver callbacks fixes Manos Pitsidianakis
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 1/4] block: pass bdrv_* methods to bs->file by default in block filters Manos Pitsidianakis
2017-07-11 17:02 ` Eric Blake
2017-07-12 10:34 ` Stefan Hajnoczi
2017-07-13 1:34 ` Eric Blake
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed Manos Pitsidianakis
2017-07-11 17:09 ` Eric Blake
2017-07-12 7:41 ` Markus Armbruster
2017-07-12 15:15 ` Kevin Wolf
2017-07-12 15:32 ` Manos Pitsidianakis
2017-07-12 10:35 ` Stefan Hajnoczi
2017-07-13 1:27 ` Eric Blake
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 3/4] block: remove bdrv_truncate callback in blkdebug Manos Pitsidianakis
2017-07-11 18:20 ` Eric Blake [this message]
2017-07-12 10:35 ` Stefan Hajnoczi
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 4/4] block: add default implementations for bdrv_co_get_block_status() Manos Pitsidianakis
2017-07-12 10:36 ` Stefan Hajnoczi
2017-07-12 7:49 ` [Qemu-devel] [PATCH v4 0/4] block: Block driver callbacks fixes Markus Armbruster
2017-07-12 8:10 ` Manos Pitsidianakis
2017-07-12 15:28 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a647abd-dfa0-4ef4-bfba-613e4f1392bd@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).