qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH] load_aout: replace bswap_needed with big_endian
Date: Sun, 23 Mar 2025 15:32:53 -0700	[thread overview]
Message-ID: <6a651ddf-8a01-40bf-9d7a-126ba69d2f95@linaro.org> (raw)
In-Reply-To: <20250320124313.819222-1-pbonzini@redhat.com>

On 3/20/25 05:43, Paolo Bonzini wrote:
> Targets know whether they are big-endian more than they know if
> the endianness is different from the host: the former is mostly
> a constant, at least in machine creation code, while the latter
> has to be computed with TARGET_BIG_ENDIAN != HOST_BIG_ENDIAN or
> something like that.
> 
> load_aout, however, takes a "bswap_needed" argument.  Replace
> it with a "big_endian" argument; even though all users are
> big-endian, it is cheap enough to keep the optional swapping
> functionality even for little-endian boards.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks, queued to tcg-next for 10.1.


r~


      parent reply	other threads:[~2025-03-23 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 12:43 [PATCH] load_aout: replace bswap_needed with big_endian Paolo Bonzini
2025-03-20 12:49 ` Philippe Mathieu-Daudé
2025-03-20 22:33 ` Pierrick Bouvier
2025-03-23 22:32 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a651ddf-8a01-40bf-9d7a-126ba69d2f95@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).