* [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype
@ 2022-10-13 13:05 Peter Maydell
2022-10-13 13:30 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Maydell @ 2022-10-13 13:05 UTC (permalink / raw)
To: qemu-devel, qemu-trivial; +Cc: Thomas Huth
In commit 1454509726719e0933c80 we removed the function
scsi_legacy_handle_cmdline() and all of its callers, but forgot to
delete the prototype from the header function. Delete the prototype
too.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
include/hw/scsi/scsi.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
index 001103488c2..9ad86b25bb4 100644
--- a/include/hw/scsi/scsi.h
+++ b/include/hw/scsi/scsi.h
@@ -187,7 +187,6 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk,
BlockdevOnError werror,
const char *serial, Error **errp);
void scsi_bus_legacy_handle_cmdline(SCSIBus *bus);
-void scsi_legacy_handle_cmdline(void);
SCSIRequest *scsi_req_alloc(const SCSIReqOps *reqops, SCSIDevice *d,
uint32_t tag, uint32_t lun, void *hba_private);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype
2022-10-13 13:05 [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype Peter Maydell
@ 2022-10-13 13:30 ` Thomas Huth
2022-10-13 18:40 ` Philippe Mathieu-Daudé via
2022-10-22 21:21 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2022-10-13 13:30 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: Paolo Bonzini, Markus Armbruster
On 13/10/2022 15.05, Peter Maydell wrote:
> In commit 1454509726719e0933c80 we removed the function
> scsi_legacy_handle_cmdline() and all of its callers, but forgot to
> delete the prototype from the header function. Delete the prototype
> too.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/scsi/scsi.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
> index 001103488c2..9ad86b25bb4 100644
> --- a/include/hw/scsi/scsi.h
> +++ b/include/hw/scsi/scsi.h
> @@ -187,7 +187,6 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk,
> BlockdevOnError werror,
> const char *serial, Error **errp);
> void scsi_bus_legacy_handle_cmdline(SCSIBus *bus);
> -void scsi_legacy_handle_cmdline(void);
>
> SCSIRequest *scsi_req_alloc(const SCSIReqOps *reqops, SCSIDevice *d,
> uint32_t tag, uint32_t lun, void *hba_private);
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype
2022-10-13 13:05 [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype Peter Maydell
2022-10-13 13:30 ` Thomas Huth
@ 2022-10-13 18:40 ` Philippe Mathieu-Daudé via
2022-10-22 21:21 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-10-13 18:40 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: Thomas Huth
On 13/10/22 15:05, Peter Maydell wrote:
> In commit 1454509726719e0933c80 we removed the function
> scsi_legacy_handle_cmdline() and all of its callers, but forgot to
> delete the prototype from the header function. Delete the prototype
> too.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/scsi/scsi.h | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype
2022-10-13 13:05 [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype Peter Maydell
2022-10-13 13:30 ` Thomas Huth
2022-10-13 18:40 ` Philippe Mathieu-Daudé via
@ 2022-10-22 21:21 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2022-10-22 21:21 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial; +Cc: Thomas Huth
Le 13/10/2022 à 15:05, Peter Maydell a écrit :
> In commit 1454509726719e0933c80 we removed the function
> scsi_legacy_handle_cmdline() and all of its callers, but forgot to
> delete the prototype from the header function. Delete the prototype
> too.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/scsi/scsi.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h
> index 001103488c2..9ad86b25bb4 100644
> --- a/include/hw/scsi/scsi.h
> +++ b/include/hw/scsi/scsi.h
> @@ -187,7 +187,6 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk,
> BlockdevOnError werror,
> const char *serial, Error **errp);
> void scsi_bus_legacy_handle_cmdline(SCSIBus *bus);
> -void scsi_legacy_handle_cmdline(void);
>
> SCSIRequest *scsi_req_alloc(const SCSIReqOps *reqops, SCSIDevice *d,
> uint32_t tag, uint32_t lun, void *hba_private);
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-24 3:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-13 13:05 [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype Peter Maydell
2022-10-13 13:30 ` Thomas Huth
2022-10-13 18:40 ` Philippe Mathieu-Daudé via
2022-10-22 21:21 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).