From: David Woodhouse <dwmw2@infradead.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: "Bin Meng" <bmeng.cn@gmail.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Guenter Roeck" <linux@roeck-us.net>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-block@nongnu.org, "Laurent Vivier" <lvivier@redhat.com>,
qemu-arm@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 04/14] hw/core: Introduce TYPE_SHARED_IRQ
Date: Thu, 09 Jan 2025 11:43:56 +0000 [thread overview]
Message-ID: <6a99c375e4fa2070e406687e5931fe48fd4837ab.camel@infradead.org> (raw)
In-Reply-To: <0481ED42-8DAB-41D5-B1F9-89D5E5756DFE@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Wed, 2025-01-08 at 14:26 +0000, Bernhard Beschow wrote:
>
>
> Am 8. Januar 2025 09:25:28 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
> > Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> > ---
> > include/hw/core/shared-irq.h | 39 ++++++++++++++++
> > hw/core/shared-irq.c | 88 ++++++++++++++++++++++++++++++++++++
> > hw/core/Kconfig | 3 ++
> > hw/core/meson.build | 1 +
> > 4 files changed, 131 insertions(+)
> > create mode 100644 include/hw/core/shared-irq.h
> > create mode 100644 hw/core/shared-irq.c
> >
> > diff --git a/include/hw/core/shared-irq.h b/include/hw/core/shared-irq.h
> > new file mode 100644
>
> As pointed out by David, this device is redundant to TYPE_OR_IRQ. I'll drop it in v2.
Of course, I'd much rather *fix* it to do a reverse callback up the
chain when the line is deasserted, to check whether any sources want it
to be asserted again. That's the only way we can do VFIO level
interrupts properly.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
next prev parent reply other threads:[~2025-01-09 11:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 9:25 [PATCH 00/14] i.MX and SDHCI improvements Bernhard Beschow
2025-01-08 9:25 ` [PATCH 01/14] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate Bernhard Beschow
2025-01-09 12:10 ` Philippe Mathieu-Daudé
2025-01-08 9:25 ` [PATCH 02/14] hw/char/imx_serial: Fix reset value of UFCR register Bernhard Beschow
2025-01-08 9:25 ` [PATCH 03/14] hw/char/imx_serial: Update all state before restarting ageing timer Bernhard Beschow
2025-01-08 9:25 ` [PATCH 04/14] hw/core: Introduce TYPE_SHARED_IRQ Bernhard Beschow
2025-01-08 13:53 ` BALATON Zoltan
2025-01-09 9:14 ` Bernhard Beschow
2025-01-08 14:26 ` Bernhard Beschow
2025-01-09 11:43 ` David Woodhouse [this message]
2025-01-08 9:25 ` [PATCH 05/14] hw/pci-host/designware: Expose MSI IRQ Bernhard Beschow
2025-01-08 9:25 ` [PATCH 06/14] hw/gpio/imx_gpio: Don't clear input GPIO values upon reset Bernhard Beschow
2025-01-08 9:25 ` [PATCH 07/14] hw/sd/sd: Remove legacy sd_set_cb() in favor of GPIOs Bernhard Beschow
2025-01-09 11:37 ` Philippe Mathieu-Daudé
2025-01-08 9:25 ` [PATCH 08/14] hw/sd/sd: Allow for inverting polarities of presence and write-protect GPIOs Bernhard Beschow
2025-01-09 11:40 ` Philippe Mathieu-Daudé
2025-01-09 16:20 ` Bernhard Beschow
2025-01-12 18:06 ` Philippe Mathieu-Daudé
2025-01-16 23:20 ` Bernhard Beschow
2025-01-17 17:24 ` Philippe Mathieu-Daudé
2025-01-08 9:25 ` [PATCH 09/14] hw/char/imx_serial: Turn some DPRINTF() statements into trace events Bernhard Beschow
2025-01-09 11:42 ` Philippe Mathieu-Daudé
2025-01-08 9:25 ` [PATCH 10/14] hw/timer/imx_gpt: Remove unused define Bernhard Beschow
2025-01-08 16:21 ` Philippe Mathieu-Daudé
2025-01-08 9:25 ` [PATCH 11/14] tests/qtest/libqos: Reuse TYPE_IMX_I2C define Bernhard Beschow
2025-01-09 11:58 ` Philippe Mathieu-Daudé
2025-01-09 14:59 ` Fabiano Rosas
2025-01-08 9:25 ` [PATCH 12/14] hw/i2c/imx_i2c: Convert DPRINTF() to trace events Bernhard Beschow
2025-01-09 11:43 ` Philippe Mathieu-Daudé
2025-01-09 11:56 ` Philippe Mathieu-Daudé
2025-01-09 12:38 ` Philippe Mathieu-Daudé
2025-01-09 16:16 ` Bernhard Beschow
2025-01-08 9:25 ` [PATCH 13/14] hw/misc/imx6_src: " Bernhard Beschow
2025-01-09 11:44 ` Philippe Mathieu-Daudé
2025-01-08 9:25 ` [PATCH 14/14] hw/gpio/imx_gpio: Turn DPRINTF() into " Bernhard Beschow
2025-01-09 11:57 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a99c375e4fa2070e406687e5931fe48fd4837ab.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=andrew.smirnov@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=farosas@suse.de \
--cc=jcd@tribudubois.net \
--cc=linux@roeck-us.net \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).