[PULL v2 0/8] Accelerators & CPU patches for 2025-11-02

[PULL v2 0/8] Accelerators & CPU patches for 2025-11-02

[Philippe Mathieu-Daudé]

The following changes since commit 53b41bb78950912ba2d9809eef6b45e4df30c647:

  Merge tag 'pull-target-arm-20251031' of https://gitlab.com/pm215/qemu into staging (2025-11-01 10:52:48 +0100)

are available in the Git repository at:

  https://github.com/philmd/qemu.git tags/accel-cpus-20251102

for you to fetch changes up to 9d01b8efc6e9621166791417f7688383f54e829f:

  rx: cpu: fix interrupts check in rx_cpu_do_interrupt() (2025-11-02 19:11:57 +0100)

Following checkpatch.pl error ignored:

  8/9 Checking commit 46f767bd6814 (tests/unit: add unit test for qemu_hexdump())
  ERROR: unnecessary whitespace before a quoted newline
  #59: FILE: tests/unit/test-cutils.c:3662:
  +            "s is \n";

  total: 1 errors, 0 warnings, 56 lines checked

----------------------------------------------------------------
Generic CPUs / accelerators patch queue

- Access CPUState::thread_kicked atomically
- Fix bql_locked status with condvar APIs
- Document cpu_memory_rw_debug()
- Rename init_clocks() -> qemu_init_clocks() to avoid name clashing
- Fix QEMU_HEXDUMP_LINE_WIDTH logic
- Fix interrupts check in rx_cpu_do_interrupt()
----------------------------------------------------------------

Alex Bennée (1):
  timers: properly prefix init_clocks()

Igor Mammedov (1):
  rx: cpu: fix interrupts check in rx_cpu_do_interrupt()

Peter Xu (1):
  bql: Fix bql_locked status with condvar APIs

Philippe Mathieu-Daudé (3):
  cpus: Access CPUState::thread_kicked atomically
  accel/tcg: Use cpu_is_stopped() helper to access CPUState::stopped
  exec/cpu: Declare cpu_memory_rw_debug() in 'hw/core/cpu.h' and
    document

Vladimir Sementsov-Ogievskiy (2):
  util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
  tests/unit: add unit test for qemu_hexdump()

 include/exec/cpu-common.h         |  4 ---
 include/hw/core/cpu.h             | 20 ++++++++++++++
 include/qemu/main-loop.h          | 18 +++++++++++++
 include/qemu/timer.h              |  5 ++--
 util/qemu-thread-common.h         |  7 +++++
 accel/tcg/tcg-accel-ops-rr.c      |  2 +-
 stubs/iothread-lock.c             |  9 +++++++
 system/cpus.c                     | 18 ++++++++++---
 target/rx/helper.c                | 45 ++++++++++++++-----------------
 tests/unit/test-aio-multithread.c |  2 +-
 tests/unit/test-cutils.c          | 45 +++++++++++++++++++++++++++++++
 util/hexdump.c                    | 38 ++++++++++++++++----------
 util/main-loop.c                  |  2 +-
 util/qemu-timer.c                 |  2 +-
 14 files changed, 164 insertions(+), 53 deletions(-)

-- 
2.51.0

Re: [PULL v2 0/8] Accelerators & CPU patches for 2025-11-02

[Richard Henderson]

On 11/2/25 19:14, Philippe Mathieu-Daudé wrote:
> Vladimir Sementsov-Ogievskiy (2):
>    util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
>    tests/unit: add unit test for qemu_hexdump()

This doesn't build:

https://gitlab.com/qemu-project/qemu/-/jobs/11947161300
https://gitlab.com/qemu-project/qemu/-/jobs/11947161195

and 10 other variations.


r~

Re: [PULL v2 0/8] Accelerators & CPU patches for 2025-11-02

[Philippe Mathieu-Daudé]

On 3/11/25 10:20, Richard Henderson wrote:
> On 11/2/25 19:14, Philippe Mathieu-Daudé wrote:
>> Vladimir Sementsov-Ogievskiy (2):
>>    util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
>>    tests/unit: add unit test for qemu_hexdump()
> 
> This doesn't build:
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/11947161300
> https://gitlab.com/qemu-project/qemu/-/jobs/11947161195
> 
> and 10 other variations.

Nice. Apologies for missing that.

Vladimir, please repost (only) the test:
https://lore.kernel.org/qemu-devel/20251031211518.38503-9-philmd@linaro.org/

Re: [PULL v2 0/8] Accelerators & CPU patches for 2025-11-02

[Vladimir Sementsov-Ogievskiy]

On 03.11.25 16:19, Philippe Mathieu-Daudé wrote:
> On 3/11/25 10:20, Richard Henderson wrote:
>> On 11/2/25 19:14, Philippe Mathieu-Daudé wrote:
>>> Vladimir Sementsov-Ogievskiy (2):
>>>    util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
>>>    tests/unit: add unit test for qemu_hexdump()
>>
>> This doesn't build:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/11947161300
>> https://gitlab.com/qemu-project/qemu/-/jobs/11947161195
>>
>> and 10 other variations.
> 
> Nice. Apologies for missing that.

Oops, my fault.

> 
> Vladimir, please repost (only) the test:
> https://lore.kernel.org/qemu-devel/20251031211518.38503-9-philmd@linaro.org/


Hmmm. But how to correctly fix it?

As I understand, the problem is that

   util_ss.add(files('hexdump.c'))

comes inside

   if have_block

block, so it miss targets without block subsystem?

Would it be more correct, to just move `util_ss.add(files('hexdump.c'))`
out of the block, so it compile always, like many other "utils"?
Actually, qemu_hexdump() itself is unrelated to block..

-- 
Best regards,
Vladimir

Re: [PULL v2 0/8] Accelerators & CPU patches for 2025-11-02

[Philippe Mathieu-Daudé]

On 4/11/25 10:54, Vladimir Sementsov-Ogievskiy wrote:
> On 03.11.25 16:19, Philippe Mathieu-Daudé wrote:
>> On 3/11/25 10:20, Richard Henderson wrote:
>>> On 11/2/25 19:14, Philippe Mathieu-Daudé wrote:
>>>> Vladimir Sementsov-Ogievskiy (2):
>>>>    util/hexdump: fix QEMU_HEXDUMP_LINE_WIDTH logic
>>>>    tests/unit: add unit test for qemu_hexdump()
>>>
>>> This doesn't build:
>>>
>>> https://gitlab.com/qemu-project/qemu/-/jobs/11947161300
>>> https://gitlab.com/qemu-project/qemu/-/jobs/11947161195
>>>
>>> and 10 other variations.
>>
>> Nice. Apologies for missing that.
> 
> Oops, my fault.
> 
>>
>> Vladimir, please repost (only) the test:
>> https://lore.kernel.org/qemu-devel/20251031211518.38503-9- 
>> philmd@linaro.org/
> 
> 
> Hmmm. But how to correctly fix it?
> 
> As I understand, the problem is that
> 
>    util_ss.add(files('hexdump.c'))
> 
> comes inside
> 
>    if have_block
> 
> block, so it miss targets without block subsystem?

Likely: we can build QEMU user emulation without system / block.

> Would it be more correct, to just move `util_ss.add(files('hexdump.c'))`
> out of the block, so it compile always, like many other "utils"?
> Actually, qemu_hexdump() itself is unrelated to block..
I concur, this should be the correct fix.

Thanks,

Phil.