From: Eric Blake <eblake@redhat.com>
To: Sahid Orentino Ferdjaoui <sferdjao@redhat.com>,
Anthony Xu <anthony.xu@intel.com>
Cc: anthony.perard@citrix.com, pbonzini@redhat.com,
sstabellini@kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] move xen-common.c to hw/xen/
Date: Thu, 6 Apr 2017 10:21:03 -0500 [thread overview]
Message-ID: <6ab9930b-1e83-c2c7-0915-78574394063f@redhat.com> (raw)
In-Reply-To: <20170406151004.GA1618@redhat>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On 04/06/2017 10:10 AM, Sahid Orentino Ferdjaoui wrote:
> On Wed, Apr 05, 2017 at 04:21:29PM -0700, Anthony Xu wrote:
>> move xen-common.c to hw/xen/
>>
>> Signed-off -by: Anthony Xu <anthony.xu@intel.com>
>
> nit: s/Signed-off -by/Signed-off-by, not sure if it's really important
> or not.
Some of the automated tooling may choke on the misspelled variant, and
S-o-b is legally important, so it is worth fixing.
By the way, you can use 'git commit -s' or 'git send-email -s' to add
S-o-b in the proper format at a given stage in your workflow, rather
than having to type it by hand; it becomes obvious that you didn't use
git's automation for adding it when you have a typo or when you have
more than one blank line between your S-o-b and the --- separator.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-04-06 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 23:21 [Qemu-devel] [PATCH 0/3] move xen related files to corresponding xen directory Anthony Xu
2017-04-05 23:21 ` [Qemu-devel] [PATCH 1/3] move xen-common.c to hw/xen/ Anthony Xu
2017-04-06 15:10 ` Sahid Orentino Ferdjaoui
2017-04-06 15:21 ` Eric Blake [this message]
2017-04-05 23:21 ` [Qemu-devel] [PATCH 2/3] move xen-hvm.c to hw/i386/xen/ Anthony Xu
2017-04-06 15:24 ` Sahid Orentino Ferdjaoui
2017-04-05 23:21 ` [Qemu-devel] [PATCH 3/3] move xen-mapcache.c " Anthony Xu
2017-04-14 18:47 ` [Qemu-devel] [PATCH 0/3] move xen related files to corresponding xen directory Stefano Stabellini
-- strict thread matches above, loose matches on Subject: below --
2017-04-05 18:39 [Qemu-devel] [PATCH 1/3] move xen-common.c to hw/xen/ Xu, Anthony
2017-04-05 18:50 ` Eric Blake
2017-04-05 22:25 ` Xu, Anthony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ab9930b-1e83-c2c7-0915-78574394063f@redhat.com \
--to=eblake@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=anthony.xu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sferdjao@redhat.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).