From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, no-reply@patchew.org
Cc: famz@redhat.com, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10
Date: Wed, 26 Jul 2017 08:06:15 -0500 [thread overview]
Message-ID: <6aca4a2d-4615-c4f5-46d6-df88448e733a@redhat.com> (raw)
In-Reply-To: <1501073395.29903.11.camel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On 07/26/2017 07:49 AM, Gerd Hoffmann wrote:
> Hi,
>
>> error message). I suspect this is caused by your use of '@ac_*'
>> instead
>> of spelling out all the ac_ members added in qapi-schema.json in 4/5
>> -
>
> Hmm, adding them all will be a pretty long list, and it will probably
> become alot longer when we add more missing keys in 2.11 ...
>
> Should this maybe summarized along the lines of "# multimedia keys
> added in 2.10"?
I'm not sure what the doc-generator will insist on, but avoiding the
@name form may be sufficient. I agree that for this particular enum,
the lists get quite long, so abbreviating may make sense, but at the
same time, being precise may be more useful for someone trying to grep
documentation.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-07-26 13:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 11:56 [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10 Gerd Hoffmann
2017-07-26 11:56 ` [Qemu-devel] [PATCH 1/5] ui: add next and prior keysyms Gerd Hoffmann
2017-07-26 12:00 ` Eric Blake
2017-07-26 11:56 ` [Qemu-devel] [PATCH 2/5] ui: move qemu_input_linux_to_qcode() Gerd Hoffmann
2017-07-26 12:14 ` Eric Blake
2017-07-26 11:56 ` [Qemu-devel] [PATCH 3/5] ui: update keymaps Gerd Hoffmann
2017-07-26 12:25 ` Eric Blake
2017-07-26 11:56 ` [Qemu-devel] [PATCH 4/5] ui: add multimedia keys Gerd Hoffmann
2017-07-26 12:02 ` Eric Blake
2017-07-26 12:08 ` Daniel P. Berrange
2017-07-26 12:12 ` Eric Blake
2017-07-26 12:38 ` Gerd Hoffmann
2017-07-26 12:24 ` Eric Blake
2017-07-26 12:39 ` Gerd Hoffmann
2017-07-26 11:56 ` [Qemu-devel] [PATCH 5/5] ps2: enable " Gerd Hoffmann
2017-07-26 12:26 ` Eric Blake
2017-07-26 12:09 ` [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10 no-reply
2017-07-26 12:22 ` Eric Blake
2017-07-26 12:49 ` Gerd Hoffmann
2017-07-26 13:06 ` Eric Blake [this message]
2017-08-08 9:20 ` Markus Armbruster
2017-08-08 15:04 ` Eric Blake
2017-08-14 6:56 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aca4a2d-4615-c4f5-46d6-df88448e733a@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=no-reply@patchew.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).