qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: qemu-stable@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha
Date: Mon, 22 Feb 2021 01:59:31 +0100	[thread overview]
Message-ID: <6aed2a0f-2859-af4a-bd67-d0a6dbd68623@gmx.de> (raw)
In-Reply-To: <20210201155922.GA18291@ls3530.fritz.box>

Dear qemu-stable,

can you please consider adding this patch to the qemu-stable branch.
Upstream commit 23b311155078bdd5bacc016ff3b3ebb5462b10c0

Thanks,
Helge

On 2/1/21 4:59 PM, Helge Deller wrote:
> The hppa and alpha targets miss the #define of the TARGET___O_TMPFILE
> and as such fail to run a trivial symlink command like
>
>      ln -s /bin/bash /tmp
>
> which results in an -EINVAL return code.
>
> Adding the define fixes the problem.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> ---
>
> diff --git a/linux-user/alpha/target_fcntl.h b/linux-user/alpha/target_fcntl.h
> index 2617e73472..0a74807a8b 100644
> --- a/linux-user/alpha/target_fcntl.h
> +++ b/linux-user/alpha/target_fcntl.h
> @@ -23,6 +23,7 @@
>   #define TARGET_O_CLOEXEC     010000000
>   #define TARGET___O_SYNC      020000000
>   #define TARGET_O_PATH        040000000
> +#define TARGET___O_TMPFILE  0100000000
>
>   #define TARGET_F_GETLK         7
>   #define TARGET_F_SETLK         8
> diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
> index bd966a59b8..08e3a4fcb0 100644
> --- a/linux-user/hppa/target_fcntl.h
> +++ b/linux-user/hppa/target_fcntl.h
> @@ -21,6 +21,7 @@
>   #define TARGET_O_CLOEXEC     010000000
>   #define TARGET___O_SYNC      000100000
>   #define TARGET_O_PATH        020000000
> +#define TARGET___O_TMPFILE   040000000
>
>   #define TARGET_F_RDLCK         1
>   #define TARGET_F_WRLCK         2
>



      parent reply	other threads:[~2021-02-22  1:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 15:59 [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha Helge Deller
2021-02-13 16:13 ` Laurent Vivier
2021-02-13 16:18 ` Laurent Vivier
2021-02-22  0:59 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6aed2a0f-2859-af4a-bd67-d0a6dbd68623@gmx.de \
    --to=deller@gmx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).