qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Tong Zhang <t.zhang2@samsung.com>,
	Ben Widawsky <ben.widawsky@intel.com>,
	 Jonathan Cameron <jonathan.cameron@huawei.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "ztong0001@gmail.com" <ztong0001@gmail.com>,
	"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] mem/cxl_type3: fix GPF DVSEC
Date: Thu, 29 Sep 2022 21:19:01 +0200	[thread overview]
Message-ID: <6afe749f-470c-8f67-0ff3-fcc78a30c50f@vivier.eu> (raw)
In-Reply-To: <20220915175853.2902-1-t.zhang2@samsung.com>

Le 15/09/2022 à 19:59, Tong Zhang a écrit :
> The structure is for device dvsec not port dvsec. Change type to fix
> this issue.
> 
> Signed-off-by: Tong Zhang <t.zhang2@samsung.com>
> ---
>   hw/mem/cxl_type3.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c
> index 3bf2869573..ada2108fac 100644
> --- a/hw/mem/cxl_type3.c
> +++ b/hw/mem/cxl_type3.c
> @@ -49,7 +49,7 @@ static void build_dvsecs(CXLType3Dev *ct3d)
>           .phase2_power = 0x33, /* 0x33 miliwatts */
>       };
>       cxl_component_create_dvsec(cxl_cstate, CXL2_TYPE3_DEVICE,
> -                               GPF_DEVICE_DVSEC_LENGTH, GPF_PORT_DVSEC,
> +                               GPF_DEVICE_DVSEC_LENGTH, GPF_DEVICE_DVSEC,
>                                  GPF_DEVICE_DVSEC_REVID, dvsec);
>   }
>   

Applied to my trivial-patches branch.

Thanks,
Laurent



      parent reply	other threads:[~2022-09-29 19:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220915175905uscas1p122c0408beff433071df5df348553be22@uscas1p1.samsung.com>
2022-09-15 17:59 ` [PATCH] mem/cxl_type3: fix GPF DVSEC Tong Zhang
2022-09-16 14:49   ` Jonathan Cameron via
2022-09-29 19:19   ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6afe749f-470c-8f67-0ff3-fcc78a30c50f@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=ben.widawsky@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=t.zhang2@samsung.com \
    --cc=ztong0001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).