qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	libvir-list@redhat.com,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [RFC PATCH-for-8.1] accel: Remove HAX accelerator
Date: Tue, 29 Aug 2023 15:38:53 +0200	[thread overview]
Message-ID: <6b0374d7-a950-8f11-caae-c80ac7fe7b3c@redhat.com> (raw)
In-Reply-To: <94bbfa23-836c-5e8c-db3b-2b040f3326a6@linaro.org>

On 24/06/2023 01.12, Philippe Mathieu-Daudé wrote:
> On 24/6/23 01:08, Philippe Mathieu-Daudé wrote:
>> HAX is deprecated since commits 73741fda6c ("MAINTAINERS: Abort
>> HAXM maintenance") and 90c167a1da ("docs/about/deprecated: Mark
>> HAXM in QEMU as deprecated"), released in v8.0.0.
>>
>> Per the QEMU deprecation policy, we shouldn't remove it before
>> QEMU release v8.2.0. However per the latest HAXM release (v7.8),
>> the latest QEMU supported is v7.2:
>>
>>    Note: Up to this release, HAXM supports QEMU from 2.9.0 to 7.2.0.
>>
>> (https://github.com/intel/haxm/releases/tag/v7.8.0)
>>
>> The next commit (https://github.com/intel/haxm/commit/da1b8ec072)
>> added:
>>
>>    HAXM v7.8.0 is our last release and we will not accept
>>    pull requests or respond to issues after this.
>>
>> As of commit b455ce4c2f, it became very hard to build and test
>> HAXM. Its previous maintainers made it clear they won't help.
>> It doesn't seem to be a very good use of QEMU maintainers to
>> spend their time in a dead project. Save our time by removing
>> this orphan zombie code before the QEMU v8.2 release.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
> 
> 
>> diff --git a/docs/about/removed-features.rst 
>> b/docs/about/removed-features.rst
>> index 5b258b446b..cc8a1e38a9 100644
>> --- a/docs/about/removed-features.rst
>> +++ b/docs/about/removed-features.rst
>> @@ -659,15 +659,18 @@ Use ``Icelake-Server`` instead.
>>   System accelerators
>>   -------------------
>> -Userspace local APIC with KVM (x86, removed 8.0)
>> +Userspace local APIC with KVM (x86, removed in 8.0)
>>   ''''''''''''''''''''''''''''''''''''''''''''''''
> 
> Oops I didn't mean to commit this line. The doc won't build with padding.

  Hi Philippe,

now that 8.1 has been released, could you please update your patch by 
removing this bad hunk and by updating the commit description?

  Thanks,
   Thomas



  reply	other threads:[~2023-08-29 13:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-23 23:08 [RFC PATCH-for-8.1] accel: Remove HAX accelerator Philippe Mathieu-Daudé
2023-06-23 23:12 ` Philippe Mathieu-Daudé
2023-08-29 13:38   ` Thomas Huth [this message]
2023-06-26  8:33 ` Richard Henderson
2023-07-06 17:31 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b0374d7-a950-8f11-caae-c80ac7fe7b3c@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=cfontana@suse.de \
    --cc=eduardo@habkost.net \
    --cc=libvir-list@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).