From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Bandan Das" <bsd@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Qiuhao Li" <Qiuhao.Li@outlook.com>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, devel@daynix.com,
"Yan Vugenfirer" <yvugenfi@redhat.com>,
"Yuri Benditovich" <yuri.benditovich@daynix.com>,
"Sriram Yagnaraman" <sriram.yagnaraman@est.tech>
Subject: Re: [PATCH 04/31] e1000: Use hw/net/mii.h
Date: Thu, 12 Jan 2023 11:42:35 +0100 [thread overview]
Message-ID: <6b0f7785-f1be-d1f5-e662-9c82008f0f42@linaro.org> (raw)
In-Reply-To: <20230112095743.20123-5-akihiko.odaki@daynix.com>
On 12/1/23 10:57, Akihiko Odaki wrote:
> hw/net/mii.h provides common definitions for MII.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> hw/net/e1000.c | 86 ++++++++++++++++++------------------
> hw/net/e1000_regs.h | 46 --------------------
> hw/net/e1000e.c | 1 +
> hw/net/e1000e_core.c | 99 +++++++++++++++++++++---------------------
> hw/net/e1000x_common.c | 5 ++-
> hw/net/e1000x_common.h | 8 ++--
> 6 files changed, 101 insertions(+), 144 deletions(-)
> static const char phy_regcap[0x20] = {
> - [PHY_STATUS] = PHY_R, [M88E1000_EXT_PHY_SPEC_CTRL] = PHY_RW,
> - [PHY_ID1] = PHY_R, [M88E1000_PHY_SPEC_CTRL] = PHY_RW,
> - [PHY_CTRL] = PHY_RW, [PHY_1000T_CTRL] = PHY_RW,
> - [PHY_LP_ABILITY] = PHY_R, [PHY_1000T_STATUS] = PHY_R,
> - [PHY_AUTONEG_ADV] = PHY_RW, [M88E1000_RX_ERR_CNTR] = PHY_R,
> - [PHY_ID2] = PHY_R, [M88E1000_PHY_SPEC_STATUS] = PHY_R,
> - [PHY_AUTONEG_EXP] = PHY_R,
> + [MII_BMSR] = PHY_R, [M88E1000_EXT_PHY_SPEC_CTRL] = PHY_RW,
Align off, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> + [MII_PHYID1] = PHY_R, [M88E1000_PHY_SPEC_CTRL] = PHY_RW,
> + [MII_BMCR] = PHY_RW, [MII_CTRL1000] = PHY_RW,
> + [MII_ANLPAR] = PHY_R, [MII_STAT1000] = PHY_R,
> + [MII_ANAR] = PHY_RW, [M88E1000_RX_ERR_CNTR] = PHY_R,
> + [MII_PHYID2] = PHY_R, [M88E1000_PHY_SPEC_STATUS] = PHY_R,
> + [MII_ANER] = PHY_R,
> };
next prev parent reply other threads:[~2023-01-12 11:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 9:57 [PATCH 00/31] Introduce igb Akihiko Odaki
2023-01-12 9:57 ` [PATCH 01/31] e1000e: Fix the code style Akihiko Odaki
2023-01-12 10:39 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 02/31] hw/net: Add more MII definitions Akihiko Odaki
2023-01-12 9:57 ` [PATCH 03/31] fsl_etsec: Use hw/net/mii.h Akihiko Odaki
2023-01-12 10:40 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 04/31] e1000: " Akihiko Odaki
2023-01-12 10:42 ` Philippe Mathieu-Daudé [this message]
2023-01-12 9:57 ` [PATCH 05/31] e1000: Mask registers when writing Akihiko Odaki
2023-01-12 9:57 ` [PATCH 06/31] e1000e: " Akihiko Odaki
2023-01-12 9:57 ` [PATCH 07/31] e1000: Use more constant definitions Akihiko Odaki
2023-01-12 10:45 ` Philippe Mathieu-Daudé
2023-01-13 0:02 ` BALATON Zoltan
2023-01-12 9:57 ` [PATCH 08/31] e1000e: " Akihiko Odaki
2023-01-12 9:57 ` [PATCH 09/31] e1000: Use memcpy to intialize registers Akihiko Odaki
2023-01-12 9:57 ` [PATCH 10/31] e1000e: " Akihiko Odaki
2023-01-12 9:57 ` [PATCH 11/31] e1000e: Remove pending interrupt flags Akihiko Odaki
2023-01-12 9:57 ` [PATCH 12/31] e1000e: Improve software reset Akihiko Odaki
2023-01-12 9:57 ` [PATCH 13/31] e1000: Configure ResettableClass Akihiko Odaki
2023-01-12 10:49 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 14/31] e1000e: " Akihiko Odaki
2023-01-12 10:49 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 15/31] e1000e: Introduce e1000_rx_desc_union Akihiko Odaki
2023-01-12 9:57 ` [PATCH 16/31] e1000e: Set MII_ANER_NWAY Akihiko Odaki
2023-01-12 10:51 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 17/31] tests/qtest/e1000e-test: Fix the code style Akihiko Odaki
2023-01-12 10:51 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 18/31] tests/qtest/libqos/e1000e: Remove duplicate register definitions Akihiko Odaki
2023-01-12 10:52 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 19/31] hw/net/net_tx_pkt: Introduce net_tx_pkt_get_eth_hdr Akihiko Odaki
2023-01-12 9:57 ` [PATCH 20/31] pcie: Introduce pcie_sriov_num_vfs Akihiko Odaki
2023-01-12 10:53 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 21/31] e1000: Split header files Akihiko Odaki
2023-01-12 11:00 ` Philippe Mathieu-Daudé
2023-01-12 9:57 ` [PATCH 22/31] igb: Copy e1000e code Akihiko Odaki
2023-01-12 9:57 ` [PATCH 23/31] igb: Rename identifiers Akihiko Odaki
2023-01-12 9:57 ` [PATCH 24/31] igb: Build igb Akihiko Odaki
2023-01-12 9:57 ` [PATCH 25/31] igb: Transform to 82576 implementation Akihiko Odaki
2023-01-12 9:57 ` [PATCH 26/31] tests/qtest/e1000e-test: Fabricate ethernet header Akihiko Odaki
2023-01-12 9:57 ` [PATCH 27/31] tests/qtest/libqos/e1000e: Export macreg functions Akihiko Odaki
2023-01-12 9:57 ` [PATCH 28/31] tests/qtest/libqos/igb: Copy e1000e code Akihiko Odaki
2023-01-12 9:57 ` [PATCH 29/31] tests/qtest/libqos/igb: Transform to igb tests Akihiko Odaki
2023-01-12 9:57 ` [PATCH 30/31] tests/avocado: Add igb test Akihiko Odaki
2023-01-12 9:57 ` [PATCH 31/31] docs/system/devices/igb: Add igb documentation Akihiko Odaki
2023-01-12 10:36 ` [PATCH 00/31] Introduce igb Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b0f7785-f1be-d1f5-e662-9c82008f0f42@linaro.org \
--to=philmd@linaro.org \
--cc=Qiuhao.Li@outlook.com \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=alxndr@bu.edu \
--cc=bleal@redhat.com \
--cc=bsd@redhat.com \
--cc=crosa@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=devel@daynix.com \
--cc=dmitry.fleytman@gmail.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sriram.yagnaraman@est.tech \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=yuri.benditovich@daynix.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).