From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BB70C7EE2F for ; Sat, 25 Feb 2023 10:10:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVrVO-0006KB-M7; Sat, 25 Feb 2023 05:10:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVrVN-0006Je-RY for qemu-devel@nongnu.org; Sat, 25 Feb 2023 05:10:13 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVrVL-0000uY-Ib for qemu-devel@nongnu.org; Sat, 25 Feb 2023 05:10:13 -0500 Received: by mail-wr1-x429.google.com with SMTP id l25so1607871wrb.3 for ; Sat, 25 Feb 2023 02:10:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R94glz4xTzI7Q1O7q2zHk79NUtEKhfWvQ4ziaKgWhew=; b=G7JRPR/DjS7w5LAg05V+jNyI5Q0rxl3ObtA6P6Yxcqzwn2WHUNLWISVTJ27i1IxsIt pXsycoeeJBy6fcHdLc7w3aHknXVD9t47qeXkAvdgJ2fAWYXyk4plnDT4v3YjyveqrFHi 6DZn+ORodqkarh5yUrFZhL8JXb5/oBZr/gsU/Eg+D4fUyVy/3JAewPvmEsUkoriWFi+y EWOmsBMD81aWrvgDz4y0z1Y7q+DTND6VFxUfqJWtdbfkLJ2kppax+ikLkFI0R4ZN6TSo 9thoXqrqSJLszkrwAm8Tr1FZ6IHPlTJiGuqNQLYLVX1QJLntqiIsE43EEQbP4ISlXY2R kGjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R94glz4xTzI7Q1O7q2zHk79NUtEKhfWvQ4ziaKgWhew=; b=7f6TWhki2cHsLd9QITxYdzMvDT7lF2bqA+Ea+Nj9N0nGial3tpxmdfsrvIgsgx95fv dmxbSeS7T5YIaQq+/Ksio/uYm8IQ471BUl3ET2Nx+M3GESzLmbPStaxs3boC6az+Jex/ POinxQWT3AqtqepLNkCvHXEdIgh9i+wqoIeLKZlRQ9hrfhGv/3Y2R0EaBYdOTH/O5NUm cKo2obaQQnRtfmCq2rDiDLdDQbHrjulb2Kj4kk0/yp/T2M/jI8RfPxvSv5ud9cwuIrnD wGYrLfQwaKt1zBCUPsTtmp7Hqdwgx8+jPr90Fd7Ilgc/C/cTDPAoctDzSZAUW4OBBPtk gEmA== X-Gm-Message-State: AO0yUKWhny4vtXukj9ZX8zH9gGAqc+/qK7ZRpSUhfI2RMGSMZhjYNbRH Ob/Pa5gwSXKG0JXHbEZBOsE09Q== X-Google-Smtp-Source: AK7set+IbDsJnjYNycjUjmvm5fYqnuPexQq2is4DefvFF2wVRsfYe4ypb/45Fmeyo7X8JIGgHNoKxw== X-Received: by 2002:adf:e58a:0:b0:2c7:d6a:cca9 with SMTP id l10-20020adfe58a000000b002c70d6acca9mr9068495wrm.23.1677319809025; Sat, 25 Feb 2023 02:10:09 -0800 (PST) Received: from [192.168.136.175] (120.red-95-127-35.staticip.rima-tde.net. [95.127.35.120]) by smtp.gmail.com with ESMTPSA id o3-20020a5d4083000000b002c5a790e959sm1365784wrp.19.2023.02.25.02.10.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Feb 2023 02:10:08 -0800 (PST) Message-ID: <6b17a5c3-143a-42ca-ec87-dd8108aac9e9@linaro.org> Date: Sat, 25 Feb 2023 11:10:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 00/76] tcg: Drop tcg_temp_free from translators Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com References: <20230225091427.1817156-1-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230225091427.1817156-1-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 25/2/23 10:13, Richard Henderson wrote: > Based-on: 20230225085945.1798188-1-richard.henderson@linaro.org > ("[PATCH v3 00/30] tcg: Simplify temporary usage") > > In the above patch set, we changed the lifetime of the temps > allocated by the guest translators, and eliminated their reuse, > so that we have the best chance of reducing their strength. > > That we don't reuse them means that we gain nothing by freeing them. > Therefore, drop all mention of tcg_temp_free from target/. > > This may be the most negative diffstat I've ever produced. :-) > 94 files changed, 471 insertions(+), 7143 deletions(-) 7143 + 2 = 7145 by removing tcg_const_ptr(): -- >8 -- diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h index 43ce4bfa7d..64b88268cd 100644 --- a/include/tcg/tcg.h +++ b/include/tcg/tcg.h @@ -1020,6 +1020,4 @@ TCGv_vec tcg_constant_vec_matching(TCGv_vec match, unsigned vece, int64_t val); #if UINTPTR_MAX == UINT32_MAX -# define tcg_const_ptr(x) ((TCGv_ptr)tcg_const_i32((intptr_t)(x))) # define tcg_constant_ptr(x) ((TCGv_ptr)tcg_constant_i32((intptr_t)(x))) #else -# define tcg_const_ptr(x) ((TCGv_ptr)tcg_const_i64((intptr_t)(x))) # define tcg_constant_ptr(x) ((TCGv_ptr)tcg_constant_i64((intptr_t)(x))) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 5bf80b22d7..ce40fac557 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -4210,3 +4210,3 @@ void gen_sve_ldr(DisasContext *s, TCGv_ptr base, int vofs, TCGLabel *loop = gen_new_label(); - TCGv_ptr tp, i = tcg_const_ptr(0); + TCGv_ptr tp, i = tcg_constant_ptr(NULL); @@ -4288,3 +4288,3 @@ void gen_sve_str(DisasContext *s, TCGv_ptr base, int vofs, TCGLabel *loop = gen_new_label(); - TCGv_ptr tp, i = tcg_const_ptr(0); + TCGv_ptr tp, i = tcg_constant_ptr(NULL); ---