From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Klaus Herman <kherman@inbox.lv>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH] hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr()
Date: Tue, 13 Oct 2020 10:34:09 +0200 [thread overview]
Message-ID: <6b392d9f-37b8-0cfc-7227-5cebcb1524b3@redhat.com> (raw)
In-Reply-To: <20201012225831.72920-1-kherman@inbox.lv>
Hi Klaus,
On 10/13/20 12:58 AM, Klaus Herman wrote:
Please include:
Fixes: bccb20c49df ("hw/core/qdev-properties: Use qemu_strtoul() in
set_pci_host_devaddr()")
You forgot to sign your patch, see:
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
> ---
> hw/core/qdev-properties-system.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
> index 49bdd12..e3dca56 100644
> --- a/hw/core/qdev-properties-system.c
> +++ b/hw/core/qdev-properties-system.c
> @@ -903,7 +903,7 @@ static void set_pci_host_devaddr(Object *obj, Visitor *v, const char *name,
> bus = val;
>
> p = (char *)e + 1;
> - if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0x1f || e == p) {
> + if (qemu_strtoul(p, &e, 16, &val) < 0 || val > 0xff || e == p) {
> goto inval;
> }
> if (*e == ':') {
>
prev parent reply other threads:[~2020-10-13 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 22:58 [PATCH] hw/core/qdev-properties: Fix pci bus range in set_pci_host_devaddr() Klaus Herman
2020-10-13 1:09 ` no-reply
2020-10-13 8:34 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b392d9f-37b8-0cfc-7227-5cebcb1524b3@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kherman@inbox.lv \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).