From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH v2 2/2] hw/pflash: implement update buffer for block writes
Date: Wed, 10 Jan 2024 08:40:28 +1100 [thread overview]
Message-ID: <6b45dc49-9eb9-4cfb-8b87-78fd51ddbd0e@linaro.org> (raw)
In-Reply-To: <20240108125342.48298-3-philmd@linaro.org>
On 1/8/24 23:53, Philippe Mathieu-Daudé wrote:
> @@ -818,6 +867,9 @@ static void pflash_cfi01_realize(DeviceState *dev, Error **errp)
> pfl->cmd = 0x00;
> pfl->status = 0x80; /* WSM ready */
> pflash_cfi01_fill_cfi_table(pfl);
> +
> + pfl->blk_bytes = g_malloc(pfl->writeblock_size);
Do you need an unrealize to free?
r~
prev parent reply other threads:[~2024-01-09 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 12:53 [PATCH v2 0/2] hw/pflash: implement update buffer for block writes Philippe Mathieu-Daudé
2024-01-08 12:53 ` [PATCH v2 1/2] hw/block/pflash_cfi01: Use the LD/ST API in pflash_data_read/write Philippe Mathieu-Daudé
2024-01-08 12:53 ` [PATCH v2 2/2] hw/pflash: implement update buffer for block writes Philippe Mathieu-Daudé
2024-01-08 13:05 ` Philippe Mathieu-Daudé
2024-01-12 16:54 ` Peter Maydell
2024-01-16 16:08 ` Philippe Mathieu-Daudé
2024-01-16 16:09 ` Peter Maydell
2024-01-17 7:52 ` Peter Xu
2024-01-09 21:40 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b45dc49-9eb9-4cfb-8b87-78fd51ddbd0e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=hreitz@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).