From: Eric Auger <eric.auger@redhat.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, ola.hugosson@arm.com
Subject: Re: [PATCH 1/2] hw/arm/smmu-common: Support 64-bit addresses
Date: Mon, 13 Feb 2023 17:22:41 +0100 [thread overview]
Message-ID: <6b4712cb-e084-b0a6-7c07-db24e2068427@redhat.com> (raw)
In-Reply-To: <20230210163731.970130-2-jean-philippe@linaro.org>
Hi Jean,
On 2/10/23 17:37, Jean-Philippe Brucker wrote:
> Addresses targeting the second translation table (TTB1) in the SMMU have
> all upper bits set. Ensure the IOMMU region covers all 64 bits.
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> hw/arm/smmu-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
> index 733c964778..2b8c67b9a1 100644
> --- a/hw/arm/smmu-common.c
> +++ b/hw/arm/smmu-common.c
> @@ -439,7 +439,7 @@ static AddressSpace *smmu_find_add_as(PCIBus *bus, void *opaque, int devfn)
>
> memory_region_init_iommu(&sdev->iommu, sizeof(sdev->iommu),
> s->mrtypename,
> - OBJECT(s), name, 1ULL << SMMU_MAX_VA_BITS);
> + OBJECT(s), name, UINT64_MAX);
as SMMU_MAX_VA_BITS is not used anymore, please remove it.
> address_space_init(&sdev->as,
> MEMORY_REGION(&sdev->iommu), name);
> trace_smmu_add_mr(name);
Thanks
Eric
next prev parent reply other threads:[~2023-02-13 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 16:37 [PATCH 0/2] hw/arm/smmu: Fixes for TTB1 Jean-Philippe Brucker
2023-02-10 16:37 ` [PATCH 1/2] hw/arm/smmu-common: Support 64-bit addresses Jean-Philippe Brucker
2023-02-11 23:28 ` Richard Henderson
2023-02-13 16:22 ` Eric Auger [this message]
2023-02-10 16:37 ` [PATCH 2/2] hw/arm/smmu-common: Fix TTB1 handling Jean-Philippe Brucker
2023-02-11 23:32 ` Richard Henderson
2023-02-13 16:30 ` Eric Auger
2023-02-14 16:46 ` Jean-Philippe Brucker
2023-02-14 18:36 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b4712cb-e084-b0a6-7c07-db24e2068427@redhat.com \
--to=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=ola.hugosson@arm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).