From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
marcandre.lureau@redhat.com
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org,
d-tatianin@yandex-team.ru,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 4/8] chardev: .chr_open(): add boolean return value
Date: Sat, 29 Nov 2025 15:08:53 +0100 [thread overview]
Message-ID: <6b47721f-0fb5-4546-abff-30746df5826b@linaro.org> (raw)
In-Reply-To: <20251129134350.487839-5-vsementsov@yandex-team.ru>
On 29/11/25 14:43, Vladimir Sementsov-Ogievskiy wrote:
> Add boolean return value to follow common recommendations for functions
> with errrp in include/qapi/error.h
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> chardev/baum.c | 5 +++--
> chardev/char-console.c | 1 +
> chardev/char-file.c | 13 +++++++------
> chardev/char-hub.c | 11 ++++++-----
> chardev/char-mux.c | 8 +++++---
> chardev/char-null.c | 4 ++--
> chardev/char-parallel.c | 14 ++++++++------
> chardev/char-pipe.c | 12 +++++++-----
> chardev/char-pty.c | 9 ++++++---
> chardev/char-ringbuf.c | 5 +++--
> chardev/char-serial.c | 15 +++++++++------
> chardev/char-socket.c | 17 +++++++++--------
> chardev/char-stdio.c | 11 ++++++-----
> chardev/char-udp.c | 5 +++--
> chardev/char-win-stdio.c | 7 ++++---
> chardev/msmouse.c | 3 ++-
> chardev/spice.c | 13 ++++++++-----
> chardev/wctablet.c | 3 ++-
> gdbstub/system.c | 3 ++-
> include/chardev/char.h | 2 +-
> ui/console-vc.c | 3 ++-
> ui/dbus-chardev.c | 6 +++---
> ui/gtk.c | 5 +++--
> ui/spice-app.c | 10 ++++++----
> ui/vdagent.c | 10 +++++-----
> 25 files changed, 113 insertions(+), 82 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-11-29 14:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 13:43 [PATCH for-11.0 0/8] chardev: cleanup Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 1/8] chardev: ChardevClass: consistent naming for handlers Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 2/8] chardev: consistent naming for ChardevClass handlers implementations Vladimir Sementsov-Ogievskiy
2025-11-29 14:07 ` Philippe Mathieu-Daudé
2025-11-29 13:43 ` [PATCH 3/8] chardev: .chr_open(): drop be_opened parameter Vladimir Sementsov-Ogievskiy
2025-12-01 12:57 ` Marc-André Lureau
2025-12-04 13:34 ` Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 4/8] chardev: .chr_open(): add boolean return value Vladimir Sementsov-Ogievskiy
2025-11-29 14:08 ` Philippe Mathieu-Daudé [this message]
2025-11-29 13:43 ` [PATCH 5/8] chardev/char-pty: store pty_name into PtyChardev state Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 6/8] chardev: introduce .chr_get_pty_name() handler Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 7/8] chardev: rework filename handling Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 8/8] chardev/char: qemu_char_open(): add return value Vladimir Sementsov-Ogievskiy
2025-11-29 14:17 ` Philippe Mathieu-Daudé
2025-12-01 13:00 ` [PATCH for-11.0 0/8] chardev: cleanup Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b47721f-0fb5-4546-abff-30746df5826b@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=d-tatianin@yandex-team.ru \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).