From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: Yuval Shaia <yuval.shaia@oracle.com>,
dgilbert@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/9] Misc fixes to pvrdma device
Date: Thu, 14 Feb 2019 16:14:17 +0200 [thread overview]
Message-ID: <6b51c177-b24e-4838-b477-3132f133dcf5@gmail.com> (raw)
In-Reply-To: <20190213065357.16076-1-yuval.shaia@oracle.com>
Hi Yuval,
On 2/13/19 8:53 AM, Yuval Shaia wrote:
> Hi,
> Please review the following patch-set which consist of cosmetics fixes to
> device's user interface (traces, error_report and monitor) and some bug
> fixes.
>
> Thanks Markus, Eric, Marcel and David for reviewing v0.
> Appreciate your review to this v2.
clang compilation fails.
Please use this configuration:
configure --target-list="x86_64-softmmu" --cc=clang --enable-pvrdma
It will fail with:
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_backend.c:32:
In file included from /home/mapfelba/git/upstream/qemu/hw/rdma/rdma_rm.h:21:
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_rm_defs.h:108:3: error:
redefinition of typedef 'RdmaDeviceResources' is a C11 feature
[-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_backend_defs.h:24:36:
note: previous definition is here
typedef struct RdmaDeviceResources RdmaDeviceResources;
^
1 error generated.
make[1]: *** [/home/mapfelba/git/upstream/qemu/rules.mak:69:
hw/rdma/rdma_backend.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from /home/mapfelba/git/upstream/qemu/hw/rdma/rdma_rm.c:21:
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_backend.h:22:
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_rm_defs.h:108:3: error:
redefinition of typedef 'RdmaDeviceResources' is a C11 feature
[-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
/home/mapfelba/git/upstream/qemu/hw/rdma/rdma_backend_defs.h:24:36:
note: previous definition is here
typedef struct RdmaDeviceResources RdmaDeviceResources;
^
1 error generated.
make[1]: *** [/home/mapfelba/git/upstream/qemu/rules.mak:69:
hw/rdma/rdma_rm.o] Error 1
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/pvrdma_qp_ops.c:19:
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_rm.h:21:
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_rm_defs.h:108:3:
error: redefinition of typedef 'RdmaDeviceResources' is a C11 feature
[-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_backend_defs.h:24:36:
note: previous definition is here
typedef struct RdmaDeviceResources RdmaDeviceResources;
^
1 error generated.
make[1]: *** [/home/mapfelba/git/upstream/qemu/rules.mak:69:
hw/rdma/vmw/pvrdma_qp_ops.o] Error 1
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/pvrdma_cmd.c:23:
In file included from
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_backend.h:22:
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_rm_defs.h:108:3:
error: redefinition of typedef 'RdmaDeviceResources' is a C11 feature
[-Werror,-Wtypedef-redefinition]
} RdmaDeviceResources;
^
/home/mapfelba/git/upstream/qemu/hw/rdma/vmw/../rdma_backend_defs.h:24:36:
note: previous definition is here
typedef struct RdmaDeviceResources RdmaDeviceResources;
^
Thanks,
Marcel
prev parent reply other threads:[~2019-02-14 14:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 6:53 [Qemu-devel] [PATCH v2 0/9] Misc fixes to pvrdma device Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 1/9] hw/rdma: Switch to generic error reporting way Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v1 2/9] hw/rdma: Introduce locked qlist Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 2/9] hw/rdma: Introduce protected qlist Yuval Shaia
2019-02-14 13:17 ` Marcel Apfelbaum
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 3/9] hw/rdma: Protect against concurrent execution of poll_cq Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface Yuval Shaia
2019-02-13 10:21 ` Dr. David Alan Gilbert
2019-02-14 13:17 ` Marcel Apfelbaum
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 5/9] hw/rdma: Free all MAD receive buffers when device is closed Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 6/9] hw/rdma: Free all receive buffers when QP is destroyed Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 7/9] hw/pvrdma: Delete unneeded function argument Yuval Shaia
2019-02-13 12:40 ` Philippe Mathieu-Daudé
2019-02-13 14:46 ` Yuval Shaia
2019-02-14 13:18 ` Marcel Apfelbaum
2019-02-13 15:40 ` Eric Blake
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 8/9] hw/pvrdma: Delete pvrdma_exit function Yuval Shaia
2019-02-13 6:53 ` [Qemu-devel] [PATCH v2 9/9] hw/pvrdma: Unregister from shutdown notifier when device goes down Yuval Shaia
2019-02-14 14:14 ` Marcel Apfelbaum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b51c177-b24e-4838-b477-3132f133dcf5@gmail.com \
--to=marcel.apfelbaum@gmail.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).