From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com,
mreitz@redhat.com, pbonzini@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v2 1/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap
Date: Thu, 19 Apr 2018 17:17:04 -0400 [thread overview]
Message-ID: <6b81372f-7d02-12d9-abaf-1bc2e4c6fbdf@redhat.com> (raw)
In-Reply-To: <20180416114414.18406-2-vsementsov@virtuozzo.com>
On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote:
> Functions write to BdrvDirtyBitmap field, so the should take the lock.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Looks like this won't introduce any recursive locking that I can spot,
so this looks correct.
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2018-04-19 21:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 11:44 [Qemu-devel] [PATCH v2 for-2.13 0/7] Dirty bitmaps fixing and refactoring Vladimir Sementsov-Ogievskiy
2018-04-16 11:44 ` [Qemu-devel] [PATCH v2 1/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap Vladimir Sementsov-Ogievskiy
2018-04-19 21:17 ` John Snow [this message]
2018-04-16 11:44 ` [Qemu-devel] [PATCH v2 2/7] dirty-bitmaps: fix comment about dirty_bitmap_mutex Vladimir Sementsov-Ogievskiy
2018-04-19 21:21 ` John Snow
2018-04-16 11:44 ` [Qemu-devel] [PATCH v2 3/7] dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header Vladimir Sementsov-Ogievskiy
2018-04-19 21:22 ` John Snow
2018-04-16 11:44 ` [Qemu-devel] [PATCH v2 4/7] dirty-bitmap: separate unused meta-bitmap related functions Vladimir Sementsov-Ogievskiy
2018-04-19 21:54 ` John Snow
2018-04-20 12:23 ` Vladimir Sementsov-Ogievskiy
2018-04-16 11:44 ` [Qemu-devel] [PATCH v2 5/7] blockdev: refactor block-dirty-bitmap-clear transaction Vladimir Sementsov-Ogievskiy
2018-04-19 22:47 ` John Snow
2018-04-20 12:32 ` Vladimir Sementsov-Ogievskiy
2018-04-19 22:59 ` John Snow
2018-04-16 11:44 ` [Qemu-devel] [PATCH v2 6/7] block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter Vladimir Sementsov-Ogievskiy
2018-04-19 22:50 ` John Snow
2018-04-16 11:44 ` [Qemu-devel] [PATCH v2 7/7] blockdev: unify block-dirty-bitmap-clear command and transaction action Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b81372f-7d02-12d9-abaf-1bc2e4c6fbdf@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).