From: Eric Blake <eblake@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: mjt@tls.msk.ru, imammedo@redhat.com, philmd@redhat.com,
peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] CODING_STYLE: specify the indent rule for multiline code
Date: Tue, 19 Feb 2019 21:02:34 -0600 [thread overview]
Message-ID: <6b850e7b-78ed-b68e-6a46-9bdbb2962507@redhat.com> (raw)
In-Reply-To: <20190220003113.20746-2-richardw.yang@linux.intel.com>
On 2/19/19 6:31 PM, Wei Yang wrote:
> We didn't specify the indent rule for multiline code here, which may
> misleading users. And in current code, the code use different rules.
s/misleading/mislead/
>
> Add this rule in CODING_STYLE to make sure this is clear to every one.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
>
> ---
> v2:
> * rephrase changelog suggested by Eric Blake
> - remove one redundant line
> - fix some awkward grammar
> - add { ; at the end of example
> ---
> CODING_STYLE | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> +
> + do_something(arg1, arg2
> + arg3);
Missing a comma after arg2. With that fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-02-20 3:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 0:31 [Qemu-devel] [PATCH v2 0/2] CODING_STYLE: trivial update Wei Yang
2019-02-20 0:31 ` [Qemu-devel] [PATCH v2 1/2] CODING_STYLE: specify the indent rule for multiline code Wei Yang
2019-02-20 3:02 ` Eric Blake [this message]
2019-02-20 3:08 ` Wei Yang
2019-02-20 0:31 ` [Qemu-devel] [PATCH v2 2/2] CODING_STYLE: indent example code as all others Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b850e7b-78ed-b68e-6a46-9bdbb2962507@redhat.com \
--to=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).