Re: [PATCH 4/5] qtest/qom-test: Don't bother to execute QMP command quit

[Steven Sistare <steven.sistare@oracle.com>]

On 7/25/2025 9:50 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   tests/qtest/qom-test.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
> index d358b69c7e..6421f2d9d9 100644
> --- a/tests/qtest/qom-test.c
> +++ b/tests/qtest/qom-test.c
> @@ -215,10 +215,6 @@ static void test_machine(gconstpointer data)
>       test_list_get(qts, paths);
>       test_list_get_value(qts);
>   
> -    response = qtest_qmp(qts, "{ 'execute': 'quit' }");
> -    g_assert(qdict_haskey(response, "return"));
> -    qobject_unref(response);
> -
>       qtest_quit(qts);
>   }

IMO the quit command improves test coverage, albeit by a small amount.
It guarantees that qemu did not die after returning the qom result to
the client.

- Steve